-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port SpikeInterface update for tutorial generation #917
Draft
CodyCBakerPhD
wants to merge
5
commits into
main
Choose a base branch
from
staging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodyCBakerPhD
changed the title
port over other PR
Port SpikeInterface update for tutorial generation
Aug 21, 2024
Looks like GitHubs just having bad service all around today |
@alejoe91 Looks like we get this error: https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/10491656279/job/29061326476?pr=917#step:13:178 Traceback (most recent call last):
File "/home/runner/miniconda3/envs/nwb-guide/lib/python3.9/site-packages/flask/app.py", line 1484, in full_dispatch_request
rv = self.dispatch_request()
File "/home/runner/miniconda3/envs/nwb-guide/lib/python3.9/site-packages/flask/app.py", line 1469, in dispatch_request
return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
File "/home/runner/miniconda3/envs/nwb-guide/lib/python3.9/site-packages/flask_restx/api.py", line 404, in wrapper
resp = resource(*args, **kwargs)
File "/home/runner/miniconda3/envs/nwb-guide/lib/python3.9/site-packages/flask/views.py", line 109, in view
return current_app.ensure_sync(self.dispatch_request)(**kwargs)
File "/home/runner/miniconda3/envs/nwb-guide/lib/python3.9/site-packages/flask_restx/resource.py", line 46, in dispatch_request
resp = meth(*args, **kwargs)
File "/home/runner/work/nwb-guide/nwb-guide/src/pyflask/namespaces/data.py", line 19, in post
generate_test_data(output_path=arguments["output_path"])
File "/home/runner/work/nwb-guide/nwb-guide/src/pyflask/manageNeuroconv/manage_neuroconv.py", line [173](https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/10491656279/job/29061326476?pr=917#step:13:174)6, in generate_test_data
spikeinterface.exporters.export_to_phy(
File "/home/runner/miniconda3/envs/nwb-guide/lib/python3.9/site-packages/spikeinterface/exporters/to_phy.py", line 184, in export_to_phy
assert templates_ext is not None, "export_to_phy requires a SortingAnalyzer with the extension 'templates'"
AssertionError: export_to_phy requires a SortingAnalyzer with the extension 'templates' Were you able to run the isolated helper function successfully on your end? (like, just a copy/paste into ipython or similar?) |
@alejoe91 Any ideas? |
@alejoe91 ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #914
replace #916
GitHub was being slow to change the merge target (took like 10 minutes to allow merge) so in less time than that I just ported over the essential changes
Let's see what CI says