Repository navigation
fix(server): align direct listener access checks - #1412
Open
pascalandr wants to merge 4 commits into
Open
pascalandr wants to merge 4 commits into
pascalandr wants to merge 4 commits into
Conversation
Use the shared browser fixture daemon for host-only controls and provide explicit local server metadata in the launcher fixture. Preserve the non-local, missing and failed metadata assertions. Wait for the asynchronous native help opener receipt before checking its destination. The same race reproduces on the public base; all expected links and interaction assertions remain unchanged. Validate the complete affected browser files and fixture wiring, 91 security cases, help coverage and server/UI/Electron typechecks.
Leave the native help opener synchronization to its existing baseline repair PR. Keep this branch limited to the shared host-only fixture daemon and explicit local launcher metadata, with the baseline failure visible.
Keep selection and expansion on live Playwright Locators keyed by data-mission-key so catalogue refreshes and retitling cannot reuse detached row handles. Preserve ordinary clicks, leaf detection and the existing selection/detail deadlines. Add deterministic real-panel remount, retitle and leaf coverage. The original helper fails the two expandable remount scenarios; the keyed helper passes all three. Document the shared browser-helper contract. UI typecheck passes; full caller validation is recorded separately.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align direct listener origin checks, host-only controls and password-session lifecycle. Keep preview capabilities and Remote Control admission consistent, with regression tests and updated help in all ten languages.
Validation: 91 targeted server tests, 12 host-only UI tests, 31 help tests, and server/UI/Electron typechecks passed locally.