Repository navigation
test(settings): await the native help opening receipt - #1410
Closed
pascalandr wants to merge 1 commit into
Closed
pascalandr wants to merge 1 commit into
pascalandr wants to merge 1 commit into
Conversation
The contextual-help test reads opened.at(-1) immediately after clicking the session-environment tip. On the local Tauri host the opener dynamically imports the native API, so the click can finish before its receipt arrives; the assertion then sees the preceding keep-awake link instead of the requested destination. Wait for the third opening receipt before the existing exact URL, disclosure and renderer assertions, matching the test's existing wait for its first two receipts. Keep all selectors, expected destinations, accessibility checks and deadlines unchanged. No product or help mapping changes. The original reproduces both failing Tauri variants; the corrected file passes all eight cases, independently repeated with pinned Node 24.22.2 in headless Chromium. Reused dependencies include a different Solid patch version than the current pin, so exact dependency qualification remains for CI.
This was referenced Nov 9, 2026
pascalandr
added a commit
that referenced
this pull request
Nov 9, 2026
The corrected Cargo graph passes all five native Tauri jobs, but the baseline still fails its build-order contract and contextual-help browser test. Require the already-present WebKit job in the exact build dependency assertion; this is the same hunk carried by #1305. Await the third native help-opening receipt before the existing URL assertion; this is the one-line correction from #1410. Keep every production change confined to the five already-reviewed lock edges. No assertion is removed, no deadline changes, and the helper opening must complete before its destination is checked. Merge current dev, which also contains the WebKit fixture-wiring correction. The independent recurrence-Pause flake is still under investigation; a green rerun is not its explanation.
Contributor
Author
|
The exact one-line receipt wait is now included in #1407 alongside the baseline Cargo and build-order contract repairs, so they can obtain one green full CI without blocking each other. Closing this duplicate proposal; no branch is deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Tauri help opener imports its native API asynchronously. The test inspected the last opening receipt immediately after the session-environment click and could still see the preceding keep-awake URL.
One-line test correction: await the third receipt before the existing assertions, using the same pattern as the first two openings.
The separate WebKit fixture checks are already corrected by #1402. The build-order contract correction belongs to #1305 and is deliberately excluded here.