Use AtomicLongFieldUpdater in StepLong, StepDouble, and AtomicDouble #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilink
commented
Sep 14, 2024
| @@ -124,4 +127,9 @@ public void max(double v) { | |||
| @Override public double doubleValue() { | |||
| return get(); | |||
| } | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
There was a problem hiding this comment.
Added a toString implementation to match the behavior of AtomicLong / AtomicInteger
kilink
force-pushed
the
atomic-field-updaters
branch
2 times, most recently
from
1ce7e11
to
e1fdb84
Compare
Use AtomicLongFieldUpdater to shrink the footprint of StepLong, StepDouble, and AtomicDouble.
kilink
force-pushed
the
atomic-field-updaters
branch
from
e1fdb84
to
645a878
Compare
|
Will need to do some testing on this, probably won't have time this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use AtomicLongFieldUpdater to shrink the footprint of StepLong, StepDouble, and AtomicDouble.
From a heapdump for a typical app, we see tens of thousands of instances of these classes:
StepLong: 21,751 instances
StepDouble: 29,233 instances
AtomicDouble 31,822 instances
Getting rid of the object reference to an AtomicLong shrinks the allocation footprint and avoids the extra pointer chasing. Note that StepLong and StepDouble still have a field
currentthat is an AtomicLong / AtomicDouble; it can't be inlined into a volatile field without breaking backwards compatibility since it is exposed via thegetCurrentmethod.