Skip to content

Fix compile warnings in mantis-control-plane-client module #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix compile warnings in mantis-control-plane-client module #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5574719
Fix deprecated getUri() in HttpRequest
mabelbot Apr 16, 2023
686e267
Fix deprecated JsonCodec(Class<T>) in JsonCodec
mabelbot Apr 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ntis-control-plane-client/src/main/java/io/mantisrx/server/master/client/HttpUtility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise)
throws Exception {
if (msg instanceof HttpRequest) {
HttpRequest request = (HttpRequest) msg;
uri = request.getUri();
uri = request.uri();
logger.info("Sending request on channel id: " + ctx.channel().toString() +
", request URI: " + uri);
}
Expand Down
5 changes: 3 additions & 2 deletions ...ol-plane-client/src/main/java/io/mantisrx/server/master/client/MantisMasterClientApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
import io.mantisrx.runtime.MantisJobDefinition;
import io.mantisrx.runtime.MantisJobState;
import io.mantisrx.runtime.WorkerMigrationConfig;
import io.mantisrx.runtime.codec.JsonCodec;
import io.mantisrx.runtime.codec.JacksonCodecs;
import io.mantisrx.runtime.descriptor.DeploymentStrategy;
import io.mantisrx.runtime.descriptor.SchedulingInfo;
import io.mantisrx.runtime.parameter.Parameter;
Expand Down Expand Up @@ -775,7 +775,8 @@ public Observable<JobAssignmentResult> assignmentResults(String jobId) {
new ConnectToObservable.Builder<JobAssignmentResult>()
.subscribeAttempts(subscribeAttemptsToMaster)
.name("/v1/api/master/assignmentresults")
.decoder(new JsonCodec<JobAssignmentResult>(JobAssignmentResult.class));
.decoder(JacksonCodecs.pojo(JobAssignmentResult.class));

if (jobId != null && !jobId.isEmpty()) {
Map<String, String> subscriptionParams = new HashMap<>();
subscriptionParams.put("jobId", jobId);
Expand Down