WIP: make belongs_to polymorphic use id_method_name
#384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #382
This is more or less a WIP to see what you guys say about this.
Some remarks:
belongs_to
without a object block. In this specific case it might be enough to use thexxx_type
column and&:id_method_name
on the parent. This would remove the need to instantiate the associated record in that case. Though then thefetch_id
method could not be used and thebelongs_to
case would be a completely separated case.run_key_transform
is not yet cached (like in other methods)What do you say about this in general?
I could think of a second way to make
belongs_to
have a complete different logic, which might speedbelongs_to
up though (if there is no need to fetch the association), but not sure if this is the way to go or if this makes the class too complex and if thexxx_type
column is enough to get the class (or if there are some edge cases where this does not work).