Compile for Linux 4.18 #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nf2util.h used to contain several misspellings of "Revision", spelled "Revsion". Correct the misspellings to silence a warning about implicit declarations. Signed-off-by: Denton Liu <[email protected]>
We were using isprint in several places but we didn't include ctype.h. Include ctype.h to silence implicit declaration warnings. Signed-off-by: Denton Liu <[email protected]>
gcc was warning about format not being a string literal with no format
arguments. Silence those warnings by doing
-printf(func())
+printf("%s", func())
Signed-off-by: Denton Liu <[email protected]>
The kernel headers were updated such that we couldn't compile netfpga
using the new headers.
Update code using preprocessor statements to be compatible with new
headers.
Here is a reference of kernel commits that introduced breaking changes:
4d659fcb20d3 ("Merge branch 'kill_trans_start'", 2016-05-04)
c835a6773314 ("net: set name_assign_type in alloc_netdev()", 2014-07-14)
1ab7b6ac2709 ("ethtool: remove phys_id from ethtool_ops", 2011-04-14)
7ad24ea4bf62 ("net: get rid of SET_ETHTOOL_OPS", 2014-05-11)
Signed-off-by: Denton Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have the hardware to test on so these changes are only compile-tested.