fix how hold time is set on element config update to not create empty…

… multi_hold_action
Nerwyn · Dec 13, 2024 · 68dbfda · 68dbfda
1 parent 9dcd58a
commit 68dbfda
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 23 deletions.
diff --git a/dist/universal-remote-card.min.js b/dist/universal-remote-card.min.js
diff --git a/src/classes/base-remote-element.ts b/src/classes/base-remote-element.ts
@@ -79,7 +79,6 @@ export class BaseRemoteElement extends LitElement {
 	}
 
 	sendAction(actionType: ActionType, config: IActions = this.config) {
-		console.log(actionType);
 		let action;
 		switch (actionType) {
 			case 'drag_action':
@@ -122,7 +121,6 @@ export class BaseRemoteElement extends LitElement {
 				action = config.tap_action;
 				break;
 		}
-		console.log(action);
 
 		if (!action) {
 			clearTimeout(this.getValueFromHassTimer);

diff --git a/src/universal-remote-card.ts b/src/universal-remote-card.ts
@@ -211,25 +211,21 @@ class UniversalRemoteCard extends LitElement {
 			}
 		}
 
-		// Set hold time if defined globally or if double tap action is defined
-		if (
-			this.config.hold_time ||
-			updatedElement.double_tap_action ||
-			updatedElement.multi_double_tap_action
-		) {
-			updatedElement.hold_action =
-				updatedElement.hold_action ?? ({} as IAction);
-			updatedElement.hold_action.hold_time =
-				updatedElement.hold_action?.hold_time ??
-				this.config.hold_time ??
-				HOLD_TIME;
-
-			updatedElement.multi_hold_action =
-				updatedElement.multi_hold_action ?? ({} as IAction);
-			updatedElement.multi_hold_action.hold_time =
-				updatedElement.multi_hold_action?.hold_time ??
-				this.config.hold_time ??
-				HOLD_TIME;
+		// Set hold time if defined globally
+		if (this.config.hold_time) {
+			if (updatedElement.hold_action) {
+				updatedElement.hold_action.hold_time =
+					updatedElement.hold_action?.hold_time ??
+					this.config.hold_time ??
+					HOLD_TIME;
+			}
+
+			if (updatedElement.multi_hold_action) {
+				updatedElement.multi_hold_action.hold_time =
+					updatedElement.multi_hold_action?.hold_time ??
+					this.config.hold_time ??
+					HOLD_TIME;
+			}
 		}
 
 		// Set repeat delay if defined globally