Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue template #964

Merged
merged 3 commits into from
Mar 8, 2025

Conversation

brysondev
Copy link
Contributor

Description

Corrected syntax of the issue/feature templates. Simplified the bug reporting template as most of the fields were unnecessary and can be asked when needed.

@brysondev brysondev requested review from blaberry and a team March 2, 2025 08:29
@AdamTadeusz
Copy link
Contributor

the machine specifics are not required fields, and the operating system probably should stay a required field. I'm not sure if this template should be changed really

@brysondev
Copy link
Contributor Author

the machine specifics are not required fields, and the operating system probably should stay a required field. I'm not sure if this template should be changed really

https://github.com/NeotokyoRebuild/neo/pull/964/files#diff-637f7b97bba458badb691a1557c3d4648686292e948dbe3e8360564378b653efR77

I left it the way it was. And personally we should discuss this as a team, but I'd still would prefer bug reports to not have so much clutter and just get to the point. Asking the same question twice shouldn't be apart of the process.

blaberry
blaberry previously approved these changes Mar 6, 2025
Copy link
Collaborator

@blaberry blaberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one nit

@kassibuss
Copy link
Contributor

Maybe we should allow to just write in the version in which the bug occurred at, unless its more useful to have the hash.

@brysondev
Copy link
Contributor Author

Maybe we should allow to just write in the version in which the bug occurred at, unless its more useful to have the hash.

That's what the hash provides? It's the tag hash and the date of release...?

@kassibuss
Copy link
Contributor

Maybe we should allow to just write in the version in which the bug occurred at, unless its more useful to have the hash.

That's what the hash provides? It's the tag hash and the date of release...?

lack of thinking moment

@brysondev
Copy link
Contributor Author

Maybe we should allow to just write in the version in which the bug occurred at, unless its more useful to have the hash.

That's what the hash provides? It's the tag hash and the date of release...?

lack of thinking moment

I do it a lot but yes please click the funny approve button

@brysondev brysondev merged commit 5d93dd0 into NeotokyoRebuild:master Mar 8, 2025
7 checks passed
@brysondev brysondev deleted the update-issue-template branch March 8, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants