muzzle light, toc flash and grenade angular impulse #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the case of the grenade angular impulses we were previously using the values Rain calculated in-game. Using cl_pdump the angular velocity of the grenade projectile is 0 in all directions so I'm guessing Rain observed the angular position of the projectiles over time and calculated them that way. The reason these are probably wrong I'm guessing is because the order in which the position in the x y and z direction is displayed is not the same as the order in which the impulse in the three directions is passed in in the grenade projectile creation function. Here are the values for a grenade projectile in the original
Once the base sdk angular impulse values are substituted in in rebuild, the angular position of the projectiles looks a lot more similar (notice the zeroed out middle column). This is despite the 0 value being the last of the three values passed for the angular impulse