New RANS models #600
New RANS models #600
Conversation
examples/periodicHill/ci.inc
Outdated
| MPI_Allreduce(MPI_IN_PLACE, &relen, 1, MPI_DFLOAT, MPI_MAX, platform->comm.mpiComm); | ||
|
|
||
| //https://turbmodels.larc.nasa.gov/Other_LES_Data/2Dhill_periodic/hill_LES_cf_digitized.dat | ||
| const auto lenLES = 4.69; |
There was a problem hiding this comment.
Please use CiEvalTest(). You'll find an example in ethier.
| @@ -0,0 +1,16 @@ | |||
| @kernel void scalarScaledAdd(const dlong N, | |||
There was a problem hiding this comment.
A kernel like this should be not needed. Use a linAlg function instead.
| @@ -0,0 +1,61 @@ | |||
| #include "intercept.oudf" | |||
|
|
|||
| @kernel void tauWallKernel(const dlong Nelements, | |||
There was a problem hiding this comment.
Why is this kernel needed? Can't we use the existing drag functio?
There was a problem hiding this comment.
I need to extract tauwall pointwise GLL array along the wall to test it against LES data. The drag function returns integrated value.
There was a problem hiding this comment.
The CI test for this case calculates the error norm of computed tau wall values against LES data (from NASA's website)
| polynomialOrder = 7 | ||
| #startFrom = r.fld | ||
|
|
||
| polynomialOrder = 3 |
There was a problem hiding this comment.
I don't think we should add an example with such a low polynomial order. It's considered to be bad practice to use a polynomial order < 5.
There was a problem hiding this comment.
I have changed polynomial order to 5. It was a challenge to keep CI test under 3 minutes. I have reduced the mesh size significantly to keep computational cost minimum.
| std::string model = "sst+des"; | ||
| RANSktau::setup(scalarFieldStart,model,o_ywd); | ||
|
|
||
| /* if(ciMode) { */ |
There was a problem hiding this comment.
remove commented code sections like this
| //if(nrs->isCheckpointStep) tavg::outfld(); | ||
|
|
||
| /* } */ | ||
| //if(nrs->isCheckpointStep) nek::userchk(); |
There was a problem hiding this comment.
remove commented code sections like this
| auto o_avg = tavg::o_avg(); | ||
| /* ciTestErrors(nrs, time, tstep, o_avg); */ | ||
|
|
||
| //if(nrs->isCheckpointStep) tavg::outfld(); |
There was a problem hiding this comment.
remove commented code sections like this
| c----------------------------------------------------------------------- | ||
| subroutine usrdat() ! This routine to modify element vertices | ||
| C----------------------------------------------------------------------- | ||
| subroutine useric(ix,iy,iz,ieg) ! set up initial conditions |
There was a problem hiding this comment.
use UDF_Setup instead of useric
src/nrs/plugins/kernels/RANSktau.okl
Outdated
| } | ||
|
|
||
| mut = rho * k * tau; | ||
| const dfloat stmagn = sqrt(2.0 * stmag2);//note: stmag2 is missing factor 2 |
|
PR doesn't compile with latest |
The following RANS models are now available:
SST based models require ywd array. User has the option to pass it through RANS::setup. If not provided, the default is to use cheap_dist
The turbulent Prandtl number in
ktauChannelcase is changed to 0.85 (from 0.7)periodicHillcase for DDES model(s)