Create nv.tsx - #95
Open
NejlaSetkic wants to merge 1 commit into
Open
Conversation
![codescene-staging-delta-analysis[bot]](https://avatars.githubusercontent.com/in/52858?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Large Method nv.tsx: Main:React.FC
Comment on lines
+28
to
+251
| export const Main: React.FC = () => { | ||
| const frame = useCurrentFrame(); | ||
|
|
||
| return ( | ||
| <div style={{flex: 1, backgroundColor: 'white'}}> | ||
| <div> | ||
| <Sequence from={0} durationInFrames={120 + 8}> | ||
| <Transition type="out"> | ||
| <Intro showText offset={0} /> | ||
| </Transition> | ||
| </Sequence> | ||
| <Sequence from={120} durationInFrames={60}> | ||
| <Transition type="in"> | ||
| <GoToGithub /> | ||
| </Transition> | ||
| </Sequence> | ||
| <Sequence from={180} durationInFrames={40}> | ||
| <Fork /> | ||
| </Sequence> | ||
| <Sequence from={220} durationInFrames={78}> | ||
| <Transition type="out"> | ||
| <InspectAndRefactor /> | ||
| </Transition> | ||
| </Sequence> | ||
| <Sequence from={290} durationInFrames={60}> | ||
| <Transition type="in"> | ||
| <PullRequest /> | ||
| </Transition> | ||
| </Sequence> | ||
| <Sequence from={350} durationInFrames={90}> | ||
| <Intro showText offset={-40} /> | ||
| </Sequence> | ||
| <Sequence from={440} durationInFrames={58}> | ||
| <Transition type="out"> | ||
| <AbsoluteFill> | ||
| <Howto /> | ||
| </AbsoluteFill> | ||
| </Transition> | ||
| </Sequence> | ||
| <Sequence from={490} durationInFrames={170}> | ||
| <Transition type="in"> | ||
| <AbsoluteFill style={{overflow: 'hidden'}}> | ||
| <Logo showText offset={0} textStartOffset={0} /> | ||
| </AbsoluteFill> | ||
| </Transition> | ||
| </Sequence> | ||
| <Sequence from={660} durationInFrames={190}> | ||
| <CodeFrame | ||
| width={1200} | ||
| title="Video.tsx" | ||
| code={` | ||
| export const RemotionVideo = () => { | ||
| return ( | ||
| <Composition | ||
| id="MyVideo" | ||
| component={MyVideo} | ||
| durationInFrames={90} | ||
| fps={30} | ||
| width={1920} | ||
| height={1080} | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| `.trim()} | ||
| timing={[ | ||
| { | ||
| line: 5, | ||
| from: 50, | ||
| }, | ||
| { | ||
| line: 6, | ||
| from: 75, | ||
| }, | ||
| { | ||
| line: 7, | ||
| from: 110, | ||
| }, | ||
| { | ||
| line: 8, | ||
| from: 115, | ||
| }, | ||
| ]} | ||
| /> | ||
| </Sequence> | ||
| <Sequence from={850} durationInFrames={240}> | ||
| <CodeFrame | ||
| width={1200} | ||
| title="MyVideo.tsx" | ||
| code={` | ||
| export const MyVideo = () => { | ||
| const frame = useCurrentFrame() // ${frame} | ||
| ${' '} | ||
| return ( | ||
| <div style={{ | ||
| display: 'flex', | ||
| justifyContent: 'center', | ||
| alignItems: 'center' | ||
| }}> | ||
| Frame number {frame} 🔥 | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| `.trim()} | ||
| timing={[ | ||
| { | ||
| line: 1, | ||
| from: 50, | ||
| }, | ||
| { | ||
| line: 3, | ||
| from: 170, | ||
| }, | ||
| { | ||
| line: 4, | ||
| from: 170, | ||
| }, | ||
| { | ||
| line: 5, | ||
| from: 170, | ||
| }, | ||
| { | ||
| line: 6, | ||
| from: 170, | ||
| }, | ||
| { | ||
| line: 7, | ||
| from: 170, | ||
| }, | ||
| { | ||
| line: 8, | ||
| from: 170, | ||
| }, | ||
| { | ||
| line: 9, | ||
| from: 170, | ||
| }, | ||
| { | ||
| line: 10, | ||
| from: 170, | ||
| }, | ||
| { | ||
| line: 11, | ||
| from: 170, | ||
| }, | ||
| ]} | ||
| /> | ||
| </Sequence> | ||
| <Sequence from={1090} durationInFrames={70}> | ||
| <WebTechnologies /> | ||
| </Sequence> | ||
| <Sequence from={1160} durationInFrames={180}> | ||
| <RemotionPlayerDemo /> | ||
| </Sequence> | ||
| <Sequence from={1340} durationInFrames={180}> | ||
| <FastRefreshDemo /> | ||
| </Sequence> | ||
| <Sequence from={1520} durationInFrames={128}> | ||
| <Transition type="out"> | ||
| <TerminalRender /> | ||
| </Transition> | ||
| </Sequence> | ||
| <Sequence from={1640} durationInFrames={80 + 9}> | ||
| <Transition type="in"> | ||
| <Transition type="out"> | ||
| <Ssr /> | ||
| </Transition> | ||
| </Transition> | ||
| </Sequence> | ||
| <Sequence from={1720} durationInFrames={120}> | ||
| <Transition type="in"> | ||
| <FadeTransition type="out" duration={9}> | ||
| <Multithreaded /> | ||
| </FadeTransition> | ||
| </Transition> | ||
| </Sequence> | ||
| <Sequence from={1840} durationInFrames={240}> | ||
| <BestQualities /> | ||
| </Sequence> | ||
| <Sequence from={2080} durationInFrames={100}> | ||
| <FadeTransition type="out" duration={5}> | ||
| <FadeTransition type="in" duration={5}> | ||
| <OpenSource /> | ||
| </FadeTransition> | ||
| </FadeTransition> | ||
| </Sequence> | ||
| <Sequence from={2180} durationInFrames={150}> | ||
| <Pricing /> | ||
| </Sequence> | ||
| <Sequence from={2330 - 10} durationInFrames={100}> | ||
| <Transition type="in"> | ||
| <Blue /> | ||
| </Transition> | ||
| </Sequence> | ||
| <Sequence from={2330} durationInFrames={180 + 8}> | ||
| <Transition type="in"> | ||
| <Transition type="out"> | ||
| <Install /> | ||
| </Transition> | ||
| </Transition> | ||
| </Sequence> | ||
| <Sequence from={2510} durationInFrames={138}> | ||
| <Transition type="in"> | ||
| <Transition type="out"> | ||
| <Website /> | ||
| </Transition> | ||
| </Transition> | ||
| </Sequence> | ||
| <Sequence from={2640} durationInFrames={289}> | ||
| <Transition type="in"> | ||
| <EndCard /> | ||
| </Transition> | ||
| </Sequence> | ||
| <Sequence from={2920} durationInFrames={14}> | ||
| <Transition type="in"> | ||
| <JustWhite /> | ||
| </Transition> | ||
| </Sequence> | ||
| <Audio src={voiceover} /> | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
❌ New issue: Large Method
Main:React.FC has 221 lines, threshold = 120
Why does this problem occur?
Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function. Read more.
To ignore this warning click here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.