Skip to content

Create isti.java - #41

Open
NejlaSetkic wants to merge 1 commit into
mainfrom
NejlaSetkic-patch-42
Open

Create isti.java#41
NejlaSetkic wants to merge 1 commit into
mainfrom
NejlaSetkic-patch-42

Conversation

@NejlaSetkic

Copy link
Copy Markdown
Owner

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
  • WHOSUSING.md
  • Other (please describe):

Changes in this PR

Describe the new behavior from this PR, and why it's needed
Issue #

Alternatives considered

Describe alternative implementation you have considered

@NejlaSetkic

Copy link
Copy Markdown
Owner Author

CodeScene PR Check


View detailed results in CodeScene

Quality Gates FAILED
Recommended Review Level Detailed -- Inspect the code that degrades in code health.

Warnings

Low Code Health for new/renamed Modules

  • isti.java has a low code health score with 4.82.

Review of New Files

1 new file(s) below the threshold for new code (5).
0 new file(s) where the code health is above the threshold.

conductor/isti.java

  • Potentially Low Cohesion: The module has at least 2 different responsibilities amongst its 57 functions.
  • File Size Issue: This module has 1261 lines of code (comments stripped away). This puts the module at risk of evolving into a Brain Class. Brain Classes are problematic since changes become more complex over time, harder to test, and challenging to refactor. Act now to prevent future maintenance issues.
  • Many Conditionals: Overall Code Complexity is measured by the mean cyclomatic complexity across all functions in the file. The lower the number, the better.
  • Complex Method: Complex implementations in: toProto (cc = 25), toProto (cc = 23), toProto (cc = 17), toProto (cc = 16), toProto (cc = 15) and 4 more functions.. A Complex Method has a high cyclomatic complexity. The recommended threshold for the Java language is a cyclomatic complexity lower than 9.
  • Code Duplication: Duplication in the functions: <code>toProto</code>, <code>fromProto</code>, <code>toProto</code>, <code>fromProto</code>, <code>toProto</code> and 7 more functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant