Skip to content

Update blog.java - #34

Open
NejlaSetkic wants to merge 1 commit into
NejlaSetkic-patch-34from
NejlaSetkic-patch-35
Open

Update blog.java#34
NejlaSetkic wants to merge 1 commit into
NejlaSetkic-patch-34from
NejlaSetkic-patch-35

Conversation

@NejlaSetkic

Copy link
Copy Markdown
Owner

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
  • WHOSUSING.md
  • Other (please describe):

Changes in this PR

Describe the new behavior from this PR, and why it's needed
Issue #

Alternatives considered

Describe alternative implementation you have considered

@NejlaSetkic

Copy link
Copy Markdown
Owner Author

CodeScene PR Check


View detailed results in CodeScene

Quality Gates FAILED
Recommended Review Level Detailed -- Inspect the code that degrades in code health.

Warnings

Degrades in Code Health

  • conductor/blog.java degrades from a Code Health of 6.98 -> 3.98

Code Health Delta Descriptions

blog.java

Improvements

  • Code Duplication - no longer an issue

Degradations

  • Lines of Code in a Single File : This module has 1549 lines of code, improve code health by reducing it to 1000 - new issue
  • String Heavy Function Arguments : In this module, 45.0% of all arguments to its 54 functions are strings. The threshold for string arguments is 39.0% - new issue
  • Brain Method : rerunWF is a brain method - new issue
  • Overall Code Complexity : This module has a mean cyclomatic complexity of 4.52 across 54 functions. The mean complexity threshold is 4 - new issue
  • Bumpy Road Ahead : rerunWF has 6 logical blocks with deeply nested code. Threshold is one single block per function, decide has 2 logical blocks with deeply nested code. Threshold is one single block per function, setTaskDomains has 2 logical blocks with deeply nested code. Threshold is one single block per function, scheduleTask has 2 logical blocks with deeply nested code. Threshold is one single block per function - getting worse
  • Complex Method : updateTask has a cyclomatic complexity of 23, threshold = 9, rerunWF has a cyclomatic complexity of 19, threshold = 9, scheduleTask has a cyclomatic complexity of 17, threshold = 9, decide has a cyclomatic complexity of 17, threshold = 9, terminateWorkflow has a cyclomatic complexity of 12, threshold = 9 and 2 more functions. - getting worse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant