Improve stamina plugin and runSpeed config option #357
Conversation
The current check is unreliable. Almost always players velocity length is higher than his walk speed. How much or less higher depends on walkSpeed config value, so it makes, for example, IsRunning function useless if walk speed is really high, or if difference between walk and run speed are pretty low.
There was a problem hiding this comment.
Overall, I don't think stripping features, moving them around, or adding new hooks to very -- VERY expensive hooks to touch, will improve anything upon the plugin.
I will make some additional commits after you will read and answer about my replies to conversations.
| local maxAttributes = ix.config.Get("maxAttributes", 100) | ||
| local offset | ||
|
|
||
| if (client:KeyDown(IN_SPEED) and client:GetVelocity():LengthSqr() >= (walkSpeed * walkSpeed)) then |
There was a problem hiding this comment.
The current check is unreliable. Almost always players velocity length is higher than his walk speed. How much or less higher depends on walkSpeed config value, so it makes, for example, IsRunning function useless if walk speed is really high, or if difference between walk and run speed are pretty low.
There was a problem hiding this comment.
You are right, Velocity:LengthSqr() is always higher than (walkSpeed * walkSpeed)
I'm not sure... why.
There was a problem hiding this comment.
The same applies to Velocity:Length, but I haven't figured out why, despite trying for an hour or something
No description provided.