Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smelter being unable to melt graphite #4171

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

out-of-phaze
Copy link
Member

Description of changes

Increases the high smelting temperature to 4000C (4273.15K), enough to melt graphite (melting point of 4074K).

Why and what will this PR improve

Fixes #4161. I understand that before it was set way too high, but like, it does need to be hot enough to melt graphite...

Authorship

Me.

@out-of-phaze out-of-phaze added the ready for review This PR is ready for review and merge. label Jul 6, 2024
@MistakeNot4892
Copy link
Contributor

Per Discord I'm not super sure about this one. Scav had issues where they put stuff into the smelter and ended up with like, white-hot vaporized metal in the atmosphere. Smelting graphite into plastic is pretty absurd as-is, if there was a chemical process we could use to replace it I think that would probably be better - maybe a plastic precursor synthesised from powdered graphite, similar to the one you find in the botany mushrooms?

I guess the other alternative would be checking that none of the common ore/mineral materials vaporize at 4kK, or just removing that aspect of the smeltery entirely.

@out-of-phaze
Copy link
Member Author

Per Discord I'm not super sure about this one. Scav had issues where they put stuff into the smelter and ended up with like, white-hot vaporized metal in the atmosphere. Smelting graphite into plastic is pretty absurd as-is, if there was a chemical process we could use to replace it I think that would probably be better - maybe a plastic precursor synthesised from powdered graphite, similar to the one you find in the botany mushrooms?

I guess the other alternative would be checking that none of the common ore/mineral materials vaporize at 4kK, or just removing that aspect of the smeltery entirely.

you need to smelt graphite to alloy it with iron and make steel, it's not the compressor, which is what turns graphite into plastic. i'd be fine with removing it personally, or limiting it to just water vapor so that you get punished for just shoving ice in there

@MistakeNot4892 MistakeNot4892 added awaiting author This PR is awaiting action from the author before it can be merged. and removed ready for review This PR is ready for review and merge. labels Jul 10, 2024
@out-of-phaze out-of-phaze added ready for review This PR is ready for review and merge. and removed awaiting author This PR is awaiting action from the author before it can be merged. labels Jul 12, 2024
@MistakeNot4892 MistakeNot4892 merged commit 3c507d7 into NebulaSS13:dev Jul 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smelter cannot process graphite
2 participants