Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent space from freezing things via gas conduction #4168

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

out-of-phaze
Copy link
Member

Description of changes

Heat transfer rate from local air to atoms now scales with air pressure.

Why and what will this PR improve

Fixes #4163.

Currently, vacuum freezes things because it's at 2.7K even though there's no gas to transfer heat to. Now, at 0kPa no heat transfer will occur, and at 10kPa it'll equalize ten times as quickly (though maybe it'd be better to cap it at a max of 1x?)

In the future we can add radiation separately, but I would much rather have the issue of hot things not cooling down (since everything that does that presently has it hardcoded separately) than everything becoming ice-cold no matter what. This is gamebreaking, a lack of radiative cooling is relatively small.

Authorship

Me.

@out-of-phaze out-of-phaze added the ready for review This PR is ready for review and merge. label Jul 6, 2024
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to revisit this if we get issues where post-fire situations are full of white-hot metal rods or whatever, but in the meantime this seems unlikely to cause serious issues.

@MistakeNot4892 MistakeNot4892 merged commit 6dfb224 into NebulaSS13:dev Jul 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vacuum makes things cold
2 participants