Fix code that indexes datum-typed variables #4159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
added
awaiting author
out-of-phaze
force-pushed
the
fix/invalid-datum-indexing
branch
from
26395d3
to
c3119d9
Compare
out-of-phaze
added
ready for review
out-of-phaze
force-pushed
the
fix/invalid-datum-indexing
branch
from
c3119d9
to
3ea25cd
Compare
| if (istype(new_data) && !isweakref(new_data)) | ||
| new_data[i] = weakref(new_data[i]) | ||
| if (istype(new_list[i], /datum) && !isweakref(new_list[i])) | ||
| new_data[i] = weakref(new_list[i]) |
There was a problem hiding this comment.
Still appears to be failing on these ones - looks like new_list is mistyped?
MistakeNot4892
added
awaiting author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes
datum[foo]which is going to be a runtime error in 516.Why and what will this PR improve
Two of these were due to type-abused vars. One was an actual issue (circuits code) which would never work due to bad copypasta.