Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted ZAS fixes #4027

Merged
merged 11 commits into from
Jun 12, 2024
Merged

Assorted ZAS fixes #4027

merged 11 commits into from
Jun 12, 2024

Conversation

NataKilar
Copy link
Contributor

@NataKilar NataKilar commented May 18, 2024

Description of changes

An assortment of ZAS fixes, mostly related to the creation of unsimulated edges between zones and space.

  • Creating a hole in the floor into space will now create an unsimulated edge as expected. This is done by checking if the zone_membership_candidate variable has changed to FALSE during a turf change. Every other case should be covered by the typical checks for exterior atmosphere participation.
  • Changed the default open_turf for flooring and natural flooring to airless variants of open space. This fixes a bug where space tiles weren't being removed from Z-stacks when the bottom most space tile was replaced by plating. I haven't tested how this affects issue Multiz shuttles replace open turfs with space. #3999 yet.
  • Doors and other atoms that need to update ZAS connections will now update their loc's neighbors if the atom is located on top of an exterior turf. This fixes a bug where unsimulated edges weren't being updated or created as expected Supplanted by new update code.
  • Fixes a longstanding issue where connections for ZAS edges in the up and down direction weren't being added to turfs' connection managers

New Changes 06/08/2024

  • You can now safely call SSair.mark_for_update on non-ZAS participating turfs to create the appropriate unsimulated edges
  • Improved consistency of updating exterior air participation. Newly ZAS participating turfs will now only assume exterior air if they were previously outside
  • Adds keep_air = TRUE to a variety of ChangeTurf calls where appropriate
  • Elevators no longer move air by default.
  • Shuttles now create roofs at their destination before moving, and only remove the roof after they have moved.

As a consequence of these changes, keep_air_below has been cut entirely.

Why and what will this PR improve

Fixes a variety of ZAS issues stemming from the simulated/unsimulated turf merger. There is still an issue with gas conservation when merging two zones between z-levels, which I still need to resolve.

Authorship

Myself. Thanks to Penny for the multi-Z get_dir code.

Changelog

🆑
bugfix: Fixed space tiles not creating vacuums in certain conditions
/:cl:

@MistakeNot4892 MistakeNot4892 added the ready for review This PR is ready for review and merge. label May 18, 2024
MistakeNot4892
MistakeNot4892 previously approved these changes May 18, 2024
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes all look good to me and you justified/explained the ones I was confused about on Discord, so looks fine to me.

@MistakeNot4892 MistakeNot4892 dismissed their stale review May 18, 2024 05:28

Bug with elevators

code/modules/multiz/basic.dm Outdated Show resolved Hide resolved
code/modules/multiz/basic.dm Outdated Show resolved Hide resolved
@MistakeNot4892 MistakeNot4892 added awaiting author This PR is awaiting action from the author before it can be merged. and removed ready for review This PR is ready for review and merge. labels May 19, 2024
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Discord, issues with elevators need to be sorted out.

@MistakeNot4892 MistakeNot4892 added this to the r6 milestone May 26, 2024
@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. and removed awaiting author This PR is awaiting action from the author before it can be merged. labels Jun 11, 2024
@comma comma merged commit fae387e into NebulaSS13:dev Jun 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants