Added quadrupedal species handling. #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
out-of-phaze
previously approved these changes
Apr 30, 2024
| hand_x_offset += world.icon_size | ||
| if(mymob.client) | ||
| mymob.client.screen |= swap_elem | ||
| if(length(swaphand_hud_objects)) |
There was a problem hiding this comment.
this if(length(swaphand_hud_objects)) check isn't strictly necessary because for (var/i in 1 to 0) will skip the loop body.
There was a problem hiding this comment.
Length check is technically a microopt over a zero iteration loop so I'm happy to leave it. <_<
MistakeNot4892
force-pushed
the
feature/quadrupeds
branch
from
5168c25
to
fee25ba
Compare
out-of-phaze
previously approved these changes
May 1, 2024
code/modules/mob/living/living.dm
Outdated
| if(T.density && T.simulated) //walls work | ||
| return TRUE | ||
| for(var/obj/O in orange(1, src)) | ||
| if(O && O.density && O.anchored) |
There was a problem hiding this comment.
might be worth changing this to include || OBJ_FLAG_SUPPORT_MOB?
MistakeNot4892
force-pushed
the
feature/quadrupeds
branch
from
fee25ba
to
536539c
Compare
out-of-phaze
previously approved these changes
May 1, 2024
MistakeNot4892
force-pushed
the
feature/quadrupeds
branch
from
536539c
to
423aefa
Compare
out-of-phaze
previously approved these changes
May 1, 2024
| @@ -0,0 +1,51 @@ | |||
| /obj/item/organ/external/leg/quadruped | |||
| name = "left rear leg" | |||
There was a problem hiding this comment.
Oh yeah this came up and I instantly forgot about it
MistakeNot4892
force-pushed
the
feature/quadrupeds
branch
from
423aefa
to
ee8eb00
Compare
out-of-phaze
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Why and what will this PR improve
More flexible bodytypes.
Supporting code for #3940.
Authorship
Myself.
Changelog
Nothing player-facing.