Fix some sprite accessory issues, misc. preferences fixes #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
out-of-phaze
force-pushed
the
fix/accessory-setup
branch
from
1f2bb90
to
e58ccbe
Compare
MistakeNot4892
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Heritable sprite accessories on DNA now properly track color.
Changing the background in character setup does not regenerate the entire mannequin.
Sprite accessory availability caching now takes into account bodytype.
Bodytype default skin and eye color is now used in pref sanitization.
reset_hairand a few other bodytype-based accessory things now properly work. Before, the lack ofaccessory_colorwould cause it to fail to add the accessory.Why and what will this PR improve
DNA will no longer entirely clear sprite accessories (including hair!).
Changing the background in character setup shouldn't cause as much server load.
Bodytype-restricted accessories will now work properly.
Default bodytype accessories and skin and eye color now properly work in more situations.