Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding metalwork. #3818

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

MistakeNot4892
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 commented Mar 21, 2024

Description of changes

  • Adds coverage checking to hot items burning the mob holding them.
  • Adds crucibles for melting down ore in a kiln.
  • Adds clay molds taken from items and used to make metal versions of those items.

Why and what will this PR improve

Another step towards bootstrap crafting from rocks to spacetech.

TODO

  • moulds need icons
  • crucible needs to announce the contents have melted
  • moulds and crucible need to handle reagents transfer
  • Add intermediary mold recipes (rods, blooms, ingots)
  • Find an anvil icon or remove the anvil definition from this PR.
  • Add metadata transfer between mold and item (casting a key and keeping the lock data)

Authorship

Crucible icon is adapted from Doe's work if I recall. Code is mine.

Changelog

🆑
add: Added metalwork.
:/cl:

@MistakeNot4892 MistakeNot4892 added the work in progress This PR is under development and shouldn't be merged. label Mar 21, 2024
@MistakeNot4892 MistakeNot4892 changed the title Working commit for metalwork. Adding metalwork. Mar 21, 2024
@MistakeNot4892 MistakeNot4892 force-pushed the feature/metalwork branch 5 times, most recently from 7c07f22 to 33411ab Compare March 21, 2024 02:02
@PsyCommando
Copy link
Contributor

So, just a thing about using clay for casting. That is, if you wanna keep it as authentic as possible.

Usually people doing small scale smelting use green sand to make molds to cast iron, steel, copper, bronze, brass, aluminium and other low-ish melting point metals. It can be re-used, and it works great for making molds of existing things. http://backyardmetalcasting.com/greensand.html
(They also use things like steel pans and muffin trays to cast ingots if its a low melting point metal.)

Using straight up clay/pottery ceramic would essentially be extremely dangerous because the water inside the clay would turn to steam instantly and project hot molten metal everywhere.

@MistakeNot4892 MistakeNot4892 force-pushed the feature/metalwork branch 5 times, most recently from 4eb0189 to cee59bd Compare April 9, 2024 23:58
@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. and removed work in progress This PR is under development and shouldn't be merged. labels Apr 9, 2024
@MistakeNot4892
Copy link
Contributor Author

This is functionally complete. There's several remaining things that I'm not sure how to approach and don't directly impact the ability to make metal stuff:

  • It's still using clay for moulds rather than foundry sand as Psy describes.
  • The crucible has no indicator that the contents have melted other than the visual overlay.

out-of-phaze
out-of-phaze previously approved these changes Apr 11, 2024
@@ -185,7 +185,8 @@
user.put_in_hands(removing)
if(lit == FIRE_LIT)
visible_message(SPAN_DANGER("\The [user] fishes \the [removing] out of \the [src]!"))
user.fire_act(return_air(), last_fuel_burn_temperature, 500)
// Uncomment this when there's a way to take stuff out of a kiln or oven without setting yourself on fire.
//user.fire_act(return_air(), last_fuel_burn_temperature, 500)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could honestly just try calling removing.try_burn_wearer(user)? but maybe that'll happen anyways. honestly i kind of think holding a hot object is punishing enough for removing one from a lit kiln as it is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's called anyway when the item is equipped.

@out-of-phaze out-of-phaze merged commit 2914bd4 into NebulaSS13:dev Apr 12, 2024
12 checks passed
@MistakeNot4892 MistakeNot4892 deleted the feature/metalwork branch May 23, 2024 02:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants