Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDB IGNORE] [IDB IGNORE] Condensing clothing state modifiers into a decl system. #3807

Merged
merged 6 commits into from
Apr 14, 2024

Conversation

MistakeNot4892
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 commented Mar 17, 2024

Description of changes

  • All the various clothing states (open, buttons, sleeves, tucked in, hood, etc) have been unified in a decl system.
  • Accessory hiding vars have been rolled into a check against the state decls.
  • Clothing icon validation has been expanded to check for onmob states based on clothing state modifiers.

Depends on #3805 #3806

Why and what will this PR improve

Consistent clothing behavior, shorter typetree, more flexible clothing code.

TODO

  • Coarse implementation/conversion.
  • Get suits and accessories passing CI.
  • Work out why verbs aren't being removed on accessory removal.
  • Verify icon updating and clothes icon updating is working on toggle.
  • See what happens to unit test time if we test states for all clothing.
  • Get all the other clothing passing CI.

Authorship

Myself.

Changelog

Nothing player-facing hopefully.

@MistakeNot4892 MistakeNot4892 added do not merge This PR is on hold, do not merge it. work in progress This PR is under development and shouldn't be merged. has dependencies This PR should not be merged prior to any PRs linked in body or comments. labels Mar 17, 2024
@MistakeNot4892 MistakeNot4892 force-pushed the rework/clothing_modifiers branch 3 times, most recently from 8566248 to 751f0e4 Compare March 17, 2024 07:01
@MistakeNot4892 MistakeNot4892 changed the title [IDB IGNORE] Condensing clothing state modifiers into a decl system. [MDB IGNORE] [IDB IGNORE] Condensing clothing state modifiers into a decl system. Mar 17, 2024
@MistakeNot4892 MistakeNot4892 force-pushed the rework/clothing_modifiers branch 2 times, most recently from e51f249 to 8784322 Compare March 17, 2024 07:34
@MistakeNot4892
Copy link
Contributor Author

Somehow testing every single clothing subtype for icon states didn't appreciably impact testing time. Perplexing.

@MistakeNot4892 MistakeNot4892 force-pushed the rework/clothing_modifiers branch 2 times, most recently from ff7d4c2 to a9d4a99 Compare March 17, 2024 10:03
@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. and removed do not merge This PR is on hold, do not merge it. work in progress This PR is under development and shouldn't be merged. labels Mar 17, 2024
@MistakeNot4892 MistakeNot4892 force-pushed the rework/clothing_modifiers branch 4 times, most recently from 05e6e04 to f36f7d1 Compare March 19, 2024 08:07
@MistakeNot4892 MistakeNot4892 removed the has dependencies This PR should not be merged prior to any PRs linked in body or comments. label Apr 4, 2024
@out-of-phaze out-of-phaze merged commit adc9222 into NebulaSS13:dev Apr 14, 2024
12 checks passed
@MistakeNot4892 MistakeNot4892 deleted the rework/clothing_modifiers branch May 23, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants