-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDB IGNORE] [IDB IGNORE] Condensing clothing state modifiers into a decl system. #3807
Merged
out-of-phaze
merged 6 commits into
NebulaSS13:dev
from
MistakeNot4892:rework/clothing_modifiers
Apr 14, 2024
Merged
[MDB IGNORE] [IDB IGNORE] Condensing clothing state modifiers into a decl system. #3807
out-of-phaze
merged 6 commits into
NebulaSS13:dev
from
MistakeNot4892:rework/clothing_modifiers
Apr 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
added
do not merge
This PR is on hold, do not merge it.
work in progress
This PR is under development and shouldn't be merged.
has dependencies
This PR should not be merged prior to any PRs linked in body or comments.
labels
Mar 17, 2024
MistakeNot4892
force-pushed
the
rework/clothing_modifiers
branch
3 times, most recently
from
March 17, 2024 07:01
8566248
to
751f0e4
Compare
MistakeNot4892
changed the title
[IDB IGNORE] Condensing clothing state modifiers into a decl system.
[MDB IGNORE] [IDB IGNORE] Condensing clothing state modifiers into a decl system.
Mar 17, 2024
MistakeNot4892
force-pushed
the
rework/clothing_modifiers
branch
2 times, most recently
from
March 17, 2024 07:34
e51f249
to
8784322
Compare
Somehow testing every single clothing subtype for icon states didn't appreciably impact testing time. Perplexing. |
MistakeNot4892
force-pushed
the
rework/clothing_modifiers
branch
2 times, most recently
from
March 17, 2024 10:03
ff7d4c2
to
a9d4a99
Compare
MistakeNot4892
added
ready for review
This PR is ready for review and merge.
and removed
do not merge
This PR is on hold, do not merge it.
work in progress
This PR is under development and shouldn't be merged.
labels
Mar 17, 2024
MistakeNot4892
force-pushed
the
rework/clothing_modifiers
branch
4 times, most recently
from
March 19, 2024 08:07
05e6e04
to
f36f7d1
Compare
comma
reviewed
Mar 26, 2024
MistakeNot4892
force-pushed
the
rework/clothing_modifiers
branch
from
April 4, 2024 05:55
e0e92a8
to
3d15600
Compare
MistakeNot4892
removed
the
has dependencies
This PR should not be merged prior to any PRs linked in body or comments.
label
Apr 4, 2024
MistakeNot4892
force-pushed
the
rework/clothing_modifiers
branch
from
April 4, 2024 08:30
3d15600
to
8d5a90a
Compare
MistakeNot4892
force-pushed
the
rework/clothing_modifiers
branch
from
April 8, 2024 04:17
8d5a90a
to
7fabc37
Compare
out-of-phaze
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Depends on #3805 #3806
Why and what will this PR improve
Consistent clothing behavior, shorter typetree, more flexible clothing code.
TODO
Authorship
Myself.
Changelog
Nothing player-facing hopefully.