Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor poster refactor. #3473

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Minor poster refactor. #3473

merged 1 commit into from
Oct 29, 2023

Conversation

MistakeNot4892
Copy link
Contributor

Description of changes

  • Removes /obj/item/contraband path.
  • Allows poster decls to set an icon.

Why and what will this PR improve

Needed for scav posters and path cleanliness.

Authorship

Myself.

Changelog

Nothing player-facing.

@MistakeNot4892 MistakeNot4892 added the ready for review This PR is ready for review and merge. label Oct 27, 2023
@MistakeNot4892 MistakeNot4892 marked this pull request as ready for review October 27, 2023 11:00
out-of-phaze
out-of-phaze approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@out-of-phaze out-of-phaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a good candidate for a migration script. /obj/item/contraband/poster : /obj/item/poster{@OLD} would be all you'd need though, so it's trivial and I really need to reorganize update_paths to not be a part of mapmerge anyway.

@out-of-phaze out-of-phaze merged commit cf1c573 into NebulaSS13:dev Oct 29, 2023
10 checks passed
@MistakeNot4892 MistakeNot4892 deleted the posters branch February 11, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@out-of-phaze out-of-phaze out-of-phaze approved these changes

Assignees
No one assigned
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MistakeNot4892 @out-of-phaze