Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readding FBP. #3468

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Readding FBP. #3468

merged 1 commit into from
Nov 3, 2023

Conversation

MistakeNot4892
Copy link
Contributor

@MistakeNot4892 MistakeNot4892 commented Oct 25, 2023 •
edited
Loading

Description of changes

  • Adds chest/head/groin aspects for prosthetic selection, gated behind the root bodytype being robotic or not.
  • Adds organ replacement logic to set_bodytype() to allow for old-style organ replacement using has_organ on the bodytype.
  • Enables the head/chest/groin recipes for the fabricator.

Why and what will this PR improve

Scav would like FBPs and the supporting code was missing following the bodytype/prosthetic rewrites.

Authorship

Myself.

Changelog

🆑
add: Synthetic bodytypes can now select head, groin and chest model customization.
/:cl:

@MistakeNot4892 MistakeNot4892 added ready for review This PR is ready for review and merge. ❄️frozen❄️ Do not merge until the dev freeze is over. labels Oct 25, 2023
@MistakeNot4892 MistakeNot4892 added do not merge This PR is on hold, do not merge it. and removed ❄️frozen❄️ Do not merge until the dev freeze is over. labels Oct 27, 2023
@MistakeNot4892 MistakeNot4892 removed the do not merge This PR is on hold, do not merge it. label Oct 27, 2023
out-of-phaze
out-of-phaze approved these changes Nov 2, 2023
View reviewed changes
code/modules/aspects/aspects_prosthetic_limbs.dm
apply_to_limb = BP_HEAD
incompatible_with_limbs = list(BP_HEAD)
fullbody_synthetic_only = TRUE
replace_children = FALSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Technically, heads don't usually have child organs. Only siblings and a parent.)

@out-of-phaze out-of-phaze merged commit 3cf7707 into NebulaSS13:dev Nov 3, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@out-of-phaze out-of-phaze out-of-phaze approved these changes

Assignees
No one assigned
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MistakeNot4892 @out-of-phaze