Rename one- and two-letter variables in crew record code

code/modules/modular_computers/file_system/reports/crew_record.dm

@@ -23,85 +23,85 @@ var/global/arrest_security_status =  "Arrest"
 	. = ..()
 	global.all_crew_records.Remove(src)
 
-/datum/computer_file/report/crew_record/proc/load_from_mob(var/mob/living/human/H)
+/datum/computer_file/report/crew_record/proc/load_from_mob(var/mob/living/human/crewmember)
 
-	if(istype(H))
-		photo_front = getFlatIcon(H, SOUTH, always_use_defdir = 1)
-		photo_side = getFlatIcon(H, WEST, always_use_defdir = 1)
+	if(istype(crewmember))
+		photo_front = getFlatIcon(crewmember, SOUTH, always_use_defdir = 1)
+		photo_side = getFlatIcon(crewmember, WEST, always_use_defdir = 1)
 	else
 		var/mob/living/human/dummy = new()
 		photo_front = getFlatIcon(dummy, SOUTH, always_use_defdir = 1)
 		photo_side = getFlatIcon(dummy, WEST, always_use_defdir = 1)
 		qdel(dummy)
 
 	// Load records from the client.
-	var/list/records = H?.client?.prefs?.records || list()
+	var/list/records = crewmember?.client?.prefs?.records || list()
 
 	// Add honorifics, etc.
 	var/formal_name = "Unset"
-	if(H)
-		formal_name = H.real_name
-		if(H.client && H.client.prefs)
-			for(var/culturetag in H.client.prefs.cultural_info)
-				var/decl/cultural_info/culture = GET_DECL(H.client.prefs.cultural_info[culturetag])
-				if(H.char_rank && H.char_rank.name_short)
+	if(crewmember)
+		formal_name = crewmember.real_name
+		if(crewmember.client && crewmember.client.prefs)
+			for(var/culturetag in crewmember.client.prefs.cultural_info)
+				var/decl/cultural_info/culture = GET_DECL(crewmember.client.prefs.cultural_info[culturetag])
+				if(crewmember.char_rank && crewmember.char_rank.name_short)
 					formal_name = "[formal_name][culture.get_formal_name_suffix()]"
 				else
 					formal_name = "[culture.get_formal_name_prefix()][formal_name][culture.get_formal_name_suffix()]"
 
 	// Generic record
-	set_name(H ? H.real_name : "Unset")
+	set_name(crewmember ? crewmember.real_name : "Unset")
 	set_formal_name(formal_name)
-	set_job(H ? GetAssignment(H) : "Unset")
+	set_job(crewmember ? GetAssignment(crewmember) : "Unset")
 	var/gender_term = "Unset"
-	if(H)
-		var/decl/pronouns/G = H.get_pronouns(ignore_coverings = TRUE)
-		if(G && G.bureaucratic_term )
-			gender_term = G.bureaucratic_term
+	if(crewmember)
+		var/decl/pronouns/gender = crewmember.get_pronouns(ignore_coverings = TRUE)
+		if(gender?.bureaucratic_term)
+			gender_term = gender.bureaucratic_term
 	set_gender(gender_term)
-	set_age(H?.get_age() || 30)
+	set_age(crewmember?.get_age() || 30)
 	set_status(global.default_physical_status)
-	set_species_name(H ? H.get_species_name() : global.using_map.default_species)
-	set_branch(H ? (H.char_branch && H.char_branch.name) : "None")
-	set_rank(H ? (H.char_rank && H.char_rank.name) : "None")
+	set_species_name(crewmember ? crewmember.get_species_name() : global.using_map.default_species)
+	set_branch(crewmember ? (crewmember.char_branch && crewmember.char_branch.name) : "None")
+	set_rank(crewmember ? (crewmember.char_rank && crewmember.char_rank.name) : "None")
 
 	var/public_record = records[PREF_PUB_RECORD]
-	set_public_record((public_record && !jobban_isbanned(H, "Records")) ? html_decode(public_record) : "No record supplied")
+	set_public_record((public_record && !jobban_isbanned(crewmember, "Records")) ? html_decode(public_record) : "No record supplied")
 
 	// Medical record
-	set_bloodtype(H?.get_blood_type() || "Unset")
+	set_bloodtype(crewmember?.get_blood_type() || "Unset")
 	var/medical_record = records[PREF_MED_RECORD]
-	set_medical_record((medical_record && !jobban_isbanned(H, "Records")) ? html_decode(medical_record) : "No record supplied")
+	set_medical_record((medical_record && !jobban_isbanned(crewmember, "Records")) ? html_decode(medical_record) : "No record supplied")
 
-	if(H)
-		var/decl/bodytype/root_bodytype = H.get_bodytype()
+	if(crewmember)
+		var/decl/bodytype/root_bodytype = crewmember.get_bodytype()
 		var/organ_data = list("\[*\]")
-		for(var/obj/item/organ/external/E in H.get_external_organs())
-			if(E.bodytype != root_bodytype)
-				organ_data += "[E.bodytype] [E.name] [BP_IS_PROSTHETIC(E) ? "prosthetic" : "graft"]"
-		for(var/obj/item/organ/internal/I in H.get_internal_organs())
-			if(I.bodytype != root_bodytype)
-				organ_data += "[I.bodytype] [I.name] [BP_IS_PROSTHETIC(I) ? "prosthetic" : "graft"]"
+		for(var/obj/item/organ/external/child in crewmember.get_external_organs())
+			if(child.bodytype != root_bodytype)
+				organ_data += "[child.bodytype] [child.name] [BP_IS_PROSTHETIC(child) ? "prosthetic" : "graft"]"
+		for(var/obj/item/organ/internal/internal_organ in crewmember.get_internal_organs())
+			if(internal_organ.bodytype != root_bodytype)
+				organ_data += "[internal_organ.bodytype] [internal_organ.name] [BP_IS_PROSTHETIC(internal_organ) ? "prosthetic" : "graft"]"
 		set_implants(jointext(organ_data, "\[*\]"))
 
 	// Security record
 	set_criminalStatus(global.default_security_status)
-	set_dna(H?.get_unique_enzymes() || "")
-	set_fingerprint(H?.get_full_print(ignore_blockers = TRUE) || "")
+	set_dna(crewmember?.get_unique_enzymes() || "")
+	set_fingerprint(crewmember?.get_full_print(ignore_blockers = TRUE) || "")
 
 	var/security_record = records[PREF_SEC_RECORD]
-	set_security_record((security_record && !jobban_isbanned(H, "Records")) ? html_decode(security_record) : "No record supplied")
+	set_security_record((security_record && !jobban_isbanned(crewmember, "Records")) ? html_decode(security_record) : "No record supplied")
 
 	// Employment record
 	var/employment_record = "No record supplied"
-	if(H)
+	if(crewmember)
 		var/gen_record = records[PREF_GEN_RECORD]
-		if(gen_record && !jobban_isbanned(H, "Records"))
+		if(gen_record && !jobban_isbanned(crewmember, "Records"))
 			employment_record = html_decode(gen_record)
-		if(H.client && H.client.prefs)
+		if(crewmember.client && crewmember.client.prefs)
 			var/list/qualifications
-			for(var/culturetag in H.client.prefs.cultural_info)
-				var/decl/cultural_info/culture = GET_DECL(H.client.prefs.cultural_info[culturetag])
+			for(var/culturetag in crewmember.client.prefs.cultural_info)
+				var/decl/cultural_info/culture = GET_DECL(crewmember.client.prefs.cultural_info[culturetag])
 				var/extra_note = culture.get_qualifications()
 				if(extra_note)
 					LAZYADD(qualifications, extra_note)
@@ -110,46 +110,46 @@ var/global/arrest_security_status =  "Arrest"
 	set_employment_record(employment_record)
 
 	// Misc cultural info.
-	set_residence(H ? html_decode(H.get_cultural_value(TAG_HOMEWORLD)) : "Unset")
-	set_faction(H ?   html_decode(H.get_cultural_value(TAG_FACTION)) :   "Unset")
-	set_religion(H ?  html_decode(H.get_cultural_value(TAG_RELIGION)) :  "Unset")
+	set_residence(crewmember ? html_decode(crewmember.get_cultural_value(TAG_HOMEWORLD)) : "Unset")
+	set_faction(crewmember ?   html_decode(crewmember.get_cultural_value(TAG_FACTION)) :   "Unset")
+	set_religion(crewmember ?  html_decode(crewmember.get_cultural_value(TAG_RELIGION)) :  "Unset")
 
-	if(H)
+	if(crewmember)
 		var/skills = list()
-		for(var/decl/hierarchy/skill/S in global.using_map.get_available_skills())
-			var/level = H.get_skill_value(S.type)
+		for(var/decl/hierarchy/skill/skill in global.using_map.get_available_skills())
+			var/level = crewmember.get_skill_value(skill.type)
 			if(level > SKILL_NONE)
-				skills += "[S.name], [S.levels[level]]"
+				skills += "[skill.name], [skill.levels[level]]"
 
 		set_skillset(jointext(skills,"\n"))
 
 	// Antag record
-	if(H?.client?.prefs)
-		var/exploit_record =  H.client.prefs.exploit_record
-		set_antag_record((exploit_record && !jobban_isbanned(H, "Records")) ? html_decode(exploit_record) : "")
+	if(crewmember?.client?.prefs)
+		var/exploit_record =  crewmember.client.prefs.exploit_record
+		set_antag_record((exploit_record && !jobban_isbanned(crewmember, "Records")) ? html_decode(exploit_record) : "")
 
 // Cut down version for silicons
-/datum/computer_file/report/crew_record/synth/load_from_mob(var/mob/living/silicon/S)
-	if(istype(S))
-		photo_front = getFlatIcon(S, SOUTH, always_use_defdir = 1)
-		photo_side = getFlatIcon(S, WEST, always_use_defdir = 1)
+/datum/computer_file/report/crew_record/synth/load_from_mob(var/mob/living/silicon/silicon_crewmember)
+	if(istype(silicon_crewmember))
+		photo_front = getFlatIcon(silicon_crewmember, SOUTH, always_use_defdir = 1)
+		photo_side = getFlatIcon(silicon_crewmember, WEST, always_use_defdir = 1)
 
 	// Generic record
-	set_name(S ? S.real_name : "Unset")
-	set_formal_name(S ? S.real_name : "Unset")
+	set_name(silicon_crewmember ? silicon_crewmember.real_name : "Unset")
+	set_formal_name(silicon_crewmember ? silicon_crewmember.real_name : "Unset")
 	set_gender("Unset")
 	set_status(global.default_physical_status)
 	var/silicon_type = "Synthetic Lifeform"
-	var/robojob = GetAssignment(S)
-	if(isrobot(S))
-		var/mob/living/silicon/robot/R = S
-		silicon_type = R.braintype
-		if(R.module)
-			robojob = "[R.module.display_name] [silicon_type]"
-	if(isAI(S))
+	var/robojob = GetAssignment(silicon_crewmember)
+	if(isrobot(silicon_crewmember))
+		var/mob/living/silicon/robot/robot = silicon_crewmember
+		silicon_type = robot.braintype
+		if(robot.module)
+			robojob = "[robot.module.display_name] [silicon_type]"
+	if(isAI(silicon_crewmember))
 		silicon_type = "AI"
 		robojob = "Artificial Intelligence"
-	set_job(S ? robojob : "Unset")
+	set_job(silicon_crewmember ? robojob : "Unset")
 	set_species_name(silicon_type)
 
 	set_implants("Robotic body")
@@ -159,57 +159,57 @@ var/global/arrest_security_status =  "Arrest"
 
 // Global methods
 // Used by character creation to create a record for new arrivals.
-/proc/CreateModularRecord(var/mob/living/H, record_type = /datum/computer_file/report/crew_record)
-	var/datum/computer_file/report/crew_record/CR = new record_type()
-	global.all_crew_records.Add(CR)
-	CR.load_from_mob(H)
-	var/datum/computer_network/network = get_local_network_at(get_turf(H))
+/proc/CreateModularRecord(var/mob/living/crewmember, record_type = /datum/computer_file/report/crew_record)
+	var/datum/computer_file/report/crew_record/crew_record = new record_type()
+	global.all_crew_records.Add(crew_record)
+	crew_record.load_from_mob(crewmember)
+	var/datum/computer_network/network = get_local_network_at(get_turf(crewmember))
 	if(network)
-		network.store_file(CR, OS_RECORDS_DIR, TRUE, mainframe_role = MF_ROLE_CREW_RECORDS)
-	return CR
+		network.store_file(crew_record, OS_RECORDS_DIR, TRUE, mainframe_role = MF_ROLE_CREW_RECORDS)
+	return crew_record
 
 // Gets crew records filtered by set of positions
 /proc/department_crew_manifest(var/list/filter_positions, var/blacklist = FALSE)
 	var/list/matches = list()
-	for(var/datum/computer_file/report/crew_record/CR in global.all_crew_records)
-		var/rank = CR.get_job()
+	for(var/datum/computer_file/report/crew_record/crew_record in global.all_crew_records)
+		var/rank = crew_record.get_job()
 		if(blacklist)
 			if(!(rank in filter_positions))
-				matches.Add(CR)
+				matches.Add(crew_record)
 		else
 			if(rank in filter_positions)
-				matches.Add(CR)
+				matches.Add(crew_record)
 	return matches
 
 // Simple record to HTML (for paper purposes) conversion.
 // Not visually that nice, but it gets the work done, feel free to tweak it visually
-/proc/record_to_html(var/datum/computer_file/report/crew_record/CR, var/access)
+/proc/record_to_html(var/datum/computer_file/report/crew_record/crew_record, var/access)
 	var/dat = "<tt><H2>RECORD DATABASE DATA DUMP</H2><i>Generated on: [stationdate2text()] [stationtime2text()]</i><br>******************************<br>"
 	dat += "<table>"
-	for(var/datum/report_field/F in CR.fields)
-		if(F.get_perms(access) & OS_READ_ACCESS)
-			dat += "<tr><td><b>[F.display_name()]</b>"
-			if(F.needs_big_box)
+	for(var/datum/report_field/field in crew_record.fields)
+		if(field.get_perms(access) & OS_READ_ACCESS)
+			dat += "<tr><td><b>[field.display_name()]</b>"
+			if(field.needs_big_box)
 				dat += "<tr>"
-			dat += "<td>[F.get_value()]"
+			dat += "<td>[field.get_value()]"
 	dat += "</tt>"
 	return dat
 
 //Should only be used for OOC stuff, for player-facing stuff you must go through the network.
 /proc/get_crewmember_record(var/name)
-	for(var/datum/computer_file/report/crew_record/CR in global.all_crew_records)
-		if(CR.get_name() == name)
-			return CR
+	for(var/datum/computer_file/report/crew_record/crew_record in global.all_crew_records)
+		if(crew_record.get_name() == name)
+			return crew_record
 	return null
 
-/proc/GetAssignment(var/mob/living/human/H)
-	if(!H)
+/proc/GetAssignment(var/mob/living/crewmember)
+	if(!crewmember)
 		return "Unassigned"
-	if(!H.mind)
-		return H.job
-	if(H.mind.role_alt_title)
-		return H.mind.role_alt_title
-	return H.mind.assigned_role
+	if(!crewmember.mind)
+		return crewmember.job
+	if(crewmember.mind.role_alt_title)
+		return crewmember.mind.role_alt_title
+	return crewmember.mind.assigned_role
 
 #define GETTER_SETTER(PATH, KEY) /datum/computer_file/report/crew_record/proc/get_##KEY(){var/datum/report_field/F = locate(/datum/report_field/##PATH/##KEY) in fields; if(F) return F.get_value()} \
 /datum/computer_file/report/crew_record/proc/set_##KEY(given_value){var/datum/report_field/F = locate(/datum/report_field/##PATH/##KEY) in fields; if(F) F.set_value(given_value)}
@@ -279,16 +279,16 @@ FIELD_LONG("Exploitable Information", antag_record, access_hacked, access_hacked
 	. |= "Unset"
 	var/list/all_genders = decls_repository.get_decls_of_type(/decl/pronouns)
 	for(var/thing in all_genders)
-		var/decl/pronouns/G = all_genders[thing]
-		if(G.bureaucratic_term )
-			. |= G.bureaucratic_term
+		var/decl/pronouns/gender = all_genders[thing]
+		if(gender.bureaucratic_term )
+			. |= gender.bureaucratic_term
 
 /datum/report_field/options/crew_record/branch/proc/record_branches()
 	. = list()
 	. |= "Unset"
-	for(var/B in mil_branches.branches)
-		var/datum/mil_branch/BR = mil_branches.branches[B]
-		. |= BR.name
+	for(var/branch in mil_branches.branches)
+		var/datum/mil_branch/branch_datum = mil_branches.branches[branch]
+		. |= branch_datum.name
 
 #undef GETTER_SETTER
 #undef SETUP_FIELD