Skip to content

Commit

Permalink
Review comments:
Browse files Browse the repository at this point in the history
- Add default value for LUSTRE_VERSION
- Don't set lustre version in Makefile/workflow
- Remove explicit setting of platform so that arm64 is also supported
  • Loading branch information
bdevcich committed Feb 12, 2025
1 parent cc78514 commit 9f9343b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 13 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ jobs:
push: true
target: production
tags: ${{ steps.meta.outputs.tags }}
build-args: LUSTRE_VERSION=cray-2.15.B19

- name: "Build the final Docker image in nektos/act"
# The docker/build-push-action does actions/checkout, and that can't be
Expand Down Expand Up @@ -153,7 +152,6 @@ jobs:
push: true
target: debug
tags: ${{ steps.meta.outputs.tags }}
build-args: LUSTRE_VERSION=cray-2.15.B19

create_release:
needs: production
Expand Down
2 changes: 2 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ ARG MPI_OPERATOR_VERSION=0.6.0
# See https://www.open-mpi.org/software/ompi/v4.1/ for releases and their checksums.
ARG OPENMPI_VERSION=4.1.7
ARG OPENMPI_MD5=787d2bc8b3db336db97c34236934b3df
# Default to the latest cray 2.15 release
ARG LUSTRE_VERSION=cray-2.15.B19

FROM mpioperator/openmpi-builder:v$MPI_OPERATOR_VERSION AS builder

Expand Down
13 changes: 2 additions & 11 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,25 +24,16 @@ IMAGE_TAG_BASE ?= ghcr.io/nearnodeflash/nnf-mfu
# tools. (i.e. podman)
CONTAINER_TOOL ?= docker

# Which tag to pull from the cray lustre source code.
# **Note:** This must also be set in .github/workflows/main.yaml for both
# production and debug docker builds.
CRAY_LUSTRE_VERSION ?= cray-2.15.B19

# Only support linux/amd64 builds. This reduces complexity with installing
# lustre, which is an option enabled for mpifileutils.
PLATFORM ?= linux/amd64

docker-build: VERSION ?= $(shell cat .version)
docker-build: TARGET ?= production
docker-build: .version
${CONTAINER_TOOL} build --platform=$(PLATFORM) --target $(TARGET) --build-arg LUSTRE_VERSION=${CRAY_LUSTRE_VERSION} -t $(IMAGE_TAG_BASE):$(VERSION) .
${CONTAINER_TOOL} build --target $(TARGET) -t $(IMAGE_TAG_BASE):$(VERSION) .

docker-build-debug: VERSION ?= $(shell cat .version)
docker-build-debug: TARGET ?= debug
docker-build-debug: IMAGE_TAG_BASE := $(IMAGE_TAG_BASE)-debug
docker-build-debug: .version
${CONTAINER_TOOL} build --platform=$(PLATFORM) --target $(TARGET) --build-arg LUSTRE_VERSION=${CRAY_LUSTRE_VERSION} -t $(IMAGE_TAG_BASE):$(VERSION) .
${CONTAINER_TOOL} build --target $(TARGET) -t $(IMAGE_TAG_BASE):$(VERSION) .

docker-push: VERSION ?= $(shell cat .version)
docker-push: .version
Expand Down

0 comments on commit 9f9343b

Please sign in to comment.