Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using DOM Nodes instead of strings #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Using DOM Nodes instead of strings #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 28 additions & 31 deletions clusterize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
self.destroy = function(clean) {
off('scroll', self.scroll_elem, scrollEv);
off('resize', window, resizeEv);
self.html((clean ? self.generateEmptyRow() : rows).join(''));
self.html((clean ? self.generateEmptyRow() : rows));
}
self.refresh = function() {
self.getRowsHeight(rows) && self.update(rows);
Expand Down Expand Up @@ -163,26 +163,23 @@
constructor: Clusterize,
// fetch existing markup
fetchMarkup: function() {
var rows = [], rows_nodes = this.getChildNodes(this.content_elem);
while (rows_nodes.length) {
rows.push(rows_nodes.shift().outerHTML);
}
return rows;
return this.getChildNodes(this.content_elem);
},
// get tag name, content tag name, tag height, calc cluster height
exploreEnvironment: function(rows) {
var opts = this.options;
opts.content_tag = this.content_elem.tagName.toLowerCase();
if( ! rows.length) return;
if(ie && ie <= 9 && ! opts.tag) opts.tag = rows[0].match(/<([^>\s/]*)/)[1].toLowerCase();
if(this.content_elem.children.length <= 1) this.html(rows[0] + rows[0] + rows[0]);
if(this.content_elem.children.length <= 1) {
this.html([rows[0], rows[1], rows[2]]);
}
if( ! opts.tag) opts.tag = this.content_elem.children[0].tagName.toLowerCase();
this.getRowsHeight(rows);
},
getRowsHeight: function(rows) {
var opts = this.options,
prev_item_height = opts.item_height;
opts.cluster_height = 0
opts.cluster_height = 0;
if( ! rows.length) return;
var nodes = this.content_elem.children;
opts.item_height = nodes[Math.floor(nodes.length / 2)].offsetHeight;
Expand Down Expand Up @@ -213,7 +210,7 @@
td.appendChild(no_data_content);
}
empty_row.appendChild(td || no_data_content);
return [empty_row.outerHTML];
return [empty_row];
},
// generate cluster for current scroll position
generate: function (rows, cluster_num) {
Expand All @@ -225,7 +222,7 @@
bottom_offset: 0,
rows_above: 0,
rows: rows_len ? rows : this.generateEmptyRow()
}
};
}
if( ! opts.cluster_height) {
this.exploreEnvironment(rows);
Expand All @@ -247,19 +244,19 @@
bottom_offset: bottom_offset,
rows_above: rows_above,
rows: this_cluster_rows
}
};
},
renderExtraTag: function(class_name, height) {
var tag = document.createElement(this.options.tag),
clusterize_prefix = 'clusterize-';
tag.className = [clusterize_prefix + 'extra-row', clusterize_prefix + class_name].join(' ');
height && (tag.style.height = height + 'px');
return tag.outerHTML;
return tag;
},
// if necessary verify data changed and insert to DOM
insertToDOM: function(rows, cache) {
var data = this.generate(rows, this.getClusterNum()),
this_cluster_rows = data.rows.join(''),
this_cluster_rows = data.rows,
this_cluster_content_changed = this.checkChanges('data', this_cluster_rows, cache),
only_bottom_offset_changed = this.checkChanges('bottom', data.bottom_offset, cache),
callbacks = this.options.callbacks,
Expand All @@ -270,33 +267,33 @@
this.options.keep_parity && layout.push(this.renderExtraTag('keep-parity'));
layout.push(this.renderExtraTag('top-space', data.top_offset));
}
layout.push(this_cluster_rows);
layout = layout.concat(this_cluster_rows);
data.bottom_offset && layout.push(this.renderExtraTag('bottom-space', data.bottom_offset));
callbacks.clusterWillChange && callbacks.clusterWillChange();
this.html(layout.join(''));
this.html(layout);
this.options.content_tag == 'ol' && this.content_elem.setAttribute('start', data.rows_above);
callbacks.clusterChanged && callbacks.clusterChanged();
} else if(only_bottom_offset_changed) {
this.content_elem.lastChild.style.height = data.bottom_offset + 'px';
}
},
// unfortunately ie <= 9 does not allow to use innerHTML for table elements, so make a workaround

empty: function(element) {
while (element.lastChild) {
element.removeChild(element.lastChild);
}
},

html: function(data) {
var content_elem = this.content_elem;
if(ie && ie <= 9 && this.options.tag == 'tr') {
var div = document.createElement('div'), last;
div.innerHTML = '<table><tbody>' + data + '</tbody></table>';
while((last = content_elem.lastChild)) {
content_elem.removeChild(last);
}
var rows_nodes = this.getChildNodes(div.firstChild.firstChild);
while (rows_nodes.length) {
content_elem.appendChild(rows_nodes.shift());
}
} else {
content_elem.innerHTML = data;

this.empty(content_elem);

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!

How about the following?

var fragment = document.createDocumentFragment();
var dataLength = data.length;

for (var i = 0; i < dataLength; i++) {
    fragment.appendChild(data[i]);
}
 content_elem.appendChild(fragment);

The document fragment should be faster

for (var i = 0; i < data.length; i++) {
content_elem.appendChild(data[i]);
}
},

getChildNodes: function(tag) {
var child_nodes = tag.children, nodes = [];
for (var i = 0, ii = child_nodes.length; i < ii; i++) {
Expand All @@ -309,7 +306,7 @@
cache[type] = value;
return changed;
}
}
};

// support functions
function on(evt, element, fnc) {
Expand All @@ -326,4 +323,4 @@
}

return Clusterize;
}));
}));