Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-pdf] annotation layer를 구현합니다. #26

Merged
merged 9 commits into from
Apr 24, 2024
Merged

[react-pdf] annotation layer를 구현합니다. #26

merged 9 commits into from
Apr 24, 2024

Conversation

2-one-week
Copy link
Member

Related Issue

Describe your changes

  • @yceffort-naver @byhhh2 님, pdf 내부 a tag 외부 링크들이 annotation layer를 통해서 구현되고 있어서, 그냥 annotation layer를 구현했습니다.
  • page 이동과 같은 불필요한 부분은 제거했습니다.
  • commit-helper 셋팅도 같이 진행했습니다. (@geonmo-nine 님 감사합니다~)

Request

@2-one-week 2-one-week self-assigned this Apr 24, 2024
@2-one-week 2-one-week requested a review from a team as a code owner April 24, 2024 09:15
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f1c2403

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

yceffort-naver
yceffort-naver approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다~

@2-one-week
Copy link
Member Author

감사합니다~

@2-one-week 2-one-week merged commit 32f2670 into epic/react_pdf Apr 24, 2024
3 checks passed
@2-one-week 2-one-week deleted the repo/24_annotation_layer branch April 24, 2024 09:32
geonmo-nine
geonmo-nine reviewed Apr 24, 2024
View reviewed changes
Copy link

@geonmo-nine geonmo-nine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업 감사합니다~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geonmo-nine geonmo-nine geonmo-nine left review comments

@yceffort-naver yceffort-naver yceffort-naver approved these changes

Assignees

@2-one-week 2-one-week

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2-one-week @yceffort-naver @geonmo-nine