Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#34] prettier 를 peerDependencies 로 이동합니다 #36

Merged
merged 2 commits into from
May 28, 2024

Conversation

geonmo-nine
Copy link
Contributor

@geonmo-nine geonmo-nine commented May 27, 2024

Related Issue

[#34] prettier 를 peerDependencies 로 이동합니다

Describe your changes

  • @naverpay/eslint-config 의 peerDependencies 에서 prettier 제거
  • @naverpay/prettier-config 의 peerDependencies 에서 prettier 추가
    +@naverpay/[email protected] 버전으로 올립니다.

@geonmo-nine geonmo-nine requested a review from a team as a code owner May 27, 2024 15:36
Copy link

changeset-bot bot commented May 27, 2024

🦋 Changeset detected

Latest commit: 2e0d208

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@naverpay/eslint-config Patch
@naverpay/prettier-config Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@geonmo-nine geonmo-nine self-assigned this May 27, 2024
Copy link
Contributor

@yceffort-naver yceffort-naver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

@@ -27,7 +27,6 @@
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-unused-imports": "^3.0.0",
"prettier": "^2.8.8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아이코 ㅋㅋ

@geonmo-nine geonmo-nine merged commit 19683ee into main May 28, 2024
2 checks passed
@geonmo-nine geonmo-nine deleted the repo/34_prettier branch May 28, 2024 00:21
@byhhh2
Copy link
Contributor

byhhh2 commented May 28, 2024

어머나..감사합니다~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants