simplify tmp file deletion for command converters

NaturalLanguage · May 6, 2013 · 4a9ea4b · 4a9ea4b
1 parent ee57256
commit 4a9ea4b
Showing 1 changed file with 8 additions and 13 deletions.
diff --git a/src/bicpi/HtmlConverter/Converter/AbstractCommandTemplate.php b/src/bicpi/HtmlConverter/Converter/AbstractCommandTemplate.php
@@ -35,20 +35,15 @@ public function convert($html)
         $path = sys_get_temp_dir() . DIRECTORY_SEPARATOR . md5(uniqid(mt_rand()));
         file_put_contents($path, $html);
 
-        try {
-            $process = new Process(sprintf($this->getCommand(), escapeshellarg($path)));
-            $process->run();
+        $process = new Process(sprintf($this->getCommand(), escapeshellarg($path)));
+        $process->run();
+
+        unlink($path);
 
-            if (!$process->isSuccessful()) {
-                throw new ConverterException($process->getErrorOutput());
-            }
-
-            return $process->getOutput();
-
-            unlink($path);
-        } catch (\Exception $e) {
-            unlink($path);
-            throw $e;
+        if (!$process->isSuccessful()) {
+            throw new ConverterException($process->getErrorOutput());
         }
+
+        return $process->getOutput();
     }
 }