Improve the performance #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hard-Coded Secrets (1)
More info on how to fix Hard-Coded Secrets in General. Vulnerable Libraries (1)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
|
This looks interesting. Let me have a look offline. Thanks for the PR |
|
Thank you for your feedback. I fixed two issues I found. I locally run the relevant ts262 tests against the code and it seems to work accordingly. you can see that the only "strange" behaviour is that "1234567890.1234567890" results not in a number, because we loose precision. Other than that, it behaves very correct. aras@aras-HP-ZBook-15-G3:~/workspace/strnum$ npm t
> [email protected] test
> jasmine *.test.js
Number("1234567890.1234567890") must return 1234567890.1234567890 Expected SameValue(«"1234567890.1234567890"», «1234567890.1234567») to be true
Number("1234567890.1234567890") must return 1234567890.1234567000 Expected SameValue(«"1234567890.1234567890"», «1234567890.1234567») to be true
Number("0.12345678901234567890") must return 0.123456789012345678 Expected SameValue(«"0.12345678901234567890"», «0.12345678901234568») to be true
Number("00.12345678901234567890") must return 0.123456789012345678 Expected SameValue(«"00.12345678901234567890"», «0.12345678901234568») to be true
Number("1234567890.1234567890") must return 1234567890.1234567890 Expected SameValue(«"1234567890.1234567890"», «1234567890.1234567») to be true
Number("1234567890.1234567890") must return 1234567890.1234567000 Expected SameValue(«"1234567890.1234567890"», «1234567890.1234567») to be true
Number("0.12345678901234567890") must return 0.123456789012345678 Expected SameValue(«"0.12345678901234567890"», «0.12345678901234568») to be true
Number("00.12345678901234567890") must return 0.123456789012345678 Expected SameValue(«"00.12345678901234567890"», «0.12345678901234568») to be true
Number(null) must return 0 Expected SameValue(«null», «0») to be true
Number(false) must return +0 Expected SameValue(«false», «0») to be true
Number(true) must return 1 Expected SameValue(«true», «1») to be true
plus sign Expected SameValue(«1», «NaN») to be true
minus sign Expected SameValue(«-1», «NaN») to be true
plus sign Expected SameValue(«16», «NaN») to be true
minus sign Expected SameValue(«-16», «NaN») to be true
plus sign Expected SameValue(«8», «NaN») to be true
minus sign Expected SameValue(«-8», «NaN») to be true
Randomized with seed 20105
Started
.................
17 specs, 0 failures
Finished in 0.013 seconds
Randomized with seed 20105 (jasmine --random=true --seed=20105) |
|
You can check my ts262 branch |
|
Thanks @Uzlopak for the update. Let me check. However, we'll be fixing the issue before final merge. |
|
What is missing it this underscore literal for numbers. Other than that it is actually quiet complete analyzer. Right now decimal character can be set via an option. I would recommend to remove it . If i set the decimal character to "," like in germany it wont be able to convert it. Or atleast we need to string replace it. Also eNotation should be considered to be separated between input and output. Also i realize that converting an octal, binary or hexadecimal numberstring is not verified if the number is not integer safe I think we should add an option for checking if the number is integer safe, and also add an option to allow floats to be converted to the next valid value as defined in the javascript spec. Like |
|
Sorry I couldn't understand much your last comment. Can you please give me an example? |
|
Performance right now see below table. Maybe it is possible to improve the performance more by an array instead of the huge switch block. Maybe have an array with 65535 entries with numeric values. Have to think about it. strnum benchmark
┌─────────┬──────────────────────────────────────────────────────────┬───────────────────┬──────────────────┬────────────────────────┬────────────────────────┬─────────┐
│ (index) │ Task name │ Latency avg (ns) │ Latency med (ns) │ Throughput avg (ops/s) │ Throughput med (ops/s) │ Samples │
├─────────┼──────────────────────────────────────────────────────────┼───────────────────┼──────────────────┼────────────────────────┼────────────────────────┼─────────┤
│ 0 │ 'undefined' │ '73.01 ± 11.18%' │ '64.00 ± 1.00' │ '15251033 ± 0.01%' │ '15625000 ± 248016' │ 1369761 │
│ 1 │ 'null' │ '67.48 ± 0.62%' │ '63.00 ± 2.00' │ '15603100 ± 0.01%' │ '15873016 ± 488401' │ 1481886 │
│ 2 │ '' │ '66.62 ± 0.40%' │ '63.00 ± 2.00' │ '15543316 ± 0.01%' │ '15873016 ± 488401' │ 1501018 │
│ 3 │ 'string' │ '132.87 ± 0.49%' │ '123.00 ± 2.00' │ '7919467 ± 0.02%' │ '8130081 ± 134382' │ 752602 │
│ 4 │ 'e89794659669cb7bb967db73a7ea6889c3891727' │ '133.47 ± 0.42%' │ '125.00 ± 2.00' │ '7813684 ± 0.02%' │ '8000000 ± 125984' │ 749230 │
│ 5 │ '12,12' │ '146.32 ± 0.45%' │ '138.00 ± 2.00' │ '7121861 ± 0.02%' │ '7246377 ± 106564' │ 683412 │
│ 6 │ '12 12' │ '179.92 ± 23.72%' │ '146.00 ± 2.00' │ '6723340 ± 0.02%' │ '6849315 ± 95129' │ 589526 │
│ 7 │ '12-12' │ '144.55 ± 0.41%' │ '138.00 ± 2.00' │ '7153892 ± 0.01%' │ '7246377 ± 103520' │ 691802 │
│ 8 │ '12.12.12' │ '168.57 ± 0.52%' │ '158.00 ± 2.00' │ '6240465 ± 0.02%' │ '6329114 ± 81143' │ 593209 │
│ 9 │ '+12' │ '217.06 ± 0.49%' │ '205.00 ± 2.00' │ '4810023 ± 0.02%' │ '4878049 ± 48060' │ 460693 │
│ 10 │ '+ 12' │ '139.57 ± 0.53%' │ '130.00 ± 2.00' │ '7549933 ± 0.02%' │ '7692308 ± 120192' │ 716496 │
│ 11 │ '12+12' │ '145.64 ± 0.43%' │ '138.00 ± 2.00' │ '7122999 ± 0.01%' │ '7246377 ± 103520' │ 686638 │
│ 12 │ '1212+' │ '160.37 ± 0.53%' │ '149.00 ± 3.00' │ '6573739 ± 0.02%' │ '6711409 ± 137905' │ 623552 │
│ 13 │ '0x2f' │ '215.68 ± 0.46%' │ '205.00 ± 2.00' │ '4824558 ± 0.02%' │ '4878049 ± 48060' │ 463654 │
│ 14 │ '-0x2f' │ '218.85 ± 0.51%' │ '206.00 ± 2.00' │ '4791772 ± 0.02%' │ '4854369 ± 47592' │ 456932 │
│ 15 │ '0x2f, {"hex":true}' │ '214.53 ± 2.59%' │ '200.00 ± 2.00' │ '4926369 ± 0.02%' │ '5000000 ± 50505' │ 466139 │
│ 16 │ '-0x2f, {"hex":true}' │ '279.95 ± 24.50%' │ '214.00 ± 7.00' │ '4600916 ± 0.04%' │ '4672897 ± 158021' │ 357205 │
│ 17 │ '0x2f, {"hex":false}' │ '163.19 ± 0.81%' │ '142.00 ± 3.00' │ '6908538 ± 0.03%' │ '7042253 ± 145701' │ 612777 │
│ 18 │ '-0x2f, {"hex":false}' │ '145.66 ± 0.45%' │ '138.00 ± 2.00' │ '7139055 ± 0.01%' │ '7246377 ± 103520' │ 686513 │
│ 19 │ '0xzz' │ '143.97 ± 0.47%' │ '134.00 ± 2.00' │ '7298195 ± 0.02%' │ '7462686 ± 113071' │ 694597 │
│ 20 │ 'iweraf0x123qwerqwer' │ '136.04 ± 0.53%' │ '126.00 ± 2.00' │ '7769155 ± 0.02%' │ '7936508 ± 124008' │ 735071 │
│ 21 │ '1230x55' │ '161.07 ± 0.43%' │ '153.00 ± 3.00' │ '6439696 ± 0.02%' │ '6535948 ± 130719' │ 620833 │
│ 22 │ 'JVBERi0xLjMNCiXi48' │ '134.56 ± 0.57%' │ '123.00 ± 2.00' │ '7926924 ± 0.02%' │ '8130081 ± 134382' │ 743176 │
│ 23 │ '0' │ '146.25 ± 0.51%' │ '137.00 ± 2.00' │ '7179300 ± 0.01%' │ '7299270 ± 108137' │ 683746 │
│ 24 │ '00' │ '149.50 ± 0.44%' │ '142.00 ± 2.00' │ '6936045 ± 0.01%' │ '7042253 ± 100604' │ 668984 │
│ 25 │ '00.0' │ '229.65 ± 0.51%' │ '216.00 ± 2.00' │ '4561688 ± 0.02%' │ '4629630 ± 43268' │ 435453 │
│ 26 │ '0, {"leadingZeros":false}' │ '146.77 ± 0.48%' │ '139.00 ± 2.00' │ '7105649 ± 0.01%' │ '7194245 ± 105025' │ 681338 │
│ 27 │ '00, {"leadingZeros":false}' │ '142.19 ± 0.43%' │ '136.00 ± 2.00' │ '7282942 ± 0.01%' │ '7352942 ± 109745' │ 703297 │
│ 28 │ '00.0, {"leadingZeros":false}' │ '139.80 ± 0.48%' │ '132.00 ± 2.00' │ '7449198 ± 0.01%' │ '7575758 ± 116550' │ 715308 │
│ 29 │ '06' │ '192.17 ± 0.52%' │ '181.00 ± 3.00' │ '5459624 ± 0.02%' │ '5524862 ± 90080' │ 520379 │
│ 30 │ '06, {"leadingZeros":true}' │ '188.86 ± 0.50%' │ '178.00 ± 2.00' │ '5535912 ± 0.01%' │ '5617977 ± 63841' │ 529487 │
│ 31 │ '06, {"leadingZeros":false}' │ '143.50 ± 0.44%' │ '137.00 ± 3.00' │ '7221960 ± 0.01%' │ '7299270 ± 156413' │ 696856 │
│ 32 │ '006' │ '199.12 ± 0.53%' │ '187.00 ± 3.00' │ '5289014 ± 0.02%' │ '5347594 ± 87189' │ 502202 │
│ 33 │ '006, {"leadingZeros":true}' │ '196.28 ± 0.48%' │ '186.00 ± 3.00' │ '5310679 ± 0.01%' │ '5376344 ± 85339' │ 509470 │
│ 34 │ '006, {"leadingZeros":false}' │ '139.54 ± 0.49%' │ '132.00 ± 2.00' │ '7487992 ± 0.01%' │ '7575758 ± 116550' │ 716627 │
│ 35 │ '000000000000000000000000017717, {"leadingZeros":false}' │ '143.81 ± 0.55%' │ '135.00 ± 2.00' │ '7325211 ± 0.01%' │ '7407408 ± 111390' │ 695370 │
│ 36 │ '000000000000000000000000017717, {"leadingZeros":true}' │ '431.23 ± 0.48%' │ '411.00 ± 4.00' │ '2409960 ± 0.02%' │ '2433090 ± 23912' │ 231893 │
│ 37 │ '0420926189200190257681175017717' │ '485.36 ± 0.58%' │ '454.00 ± 9.00' │ '2178156 ± 0.03%' │ '2202643 ± 42816' │ 206031 │
│ 38 │ '20.21.030' │ '164.55 ± 0.39%' │ '157.00 ± 2.00' │ '6269022 ± 0.01%' │ '6369427 ± 82186' │ 607724 │
│ 39 │ '0.21.030' │ '159.76 ± 0.48%' │ '150.00 ± 2.00' │ '6543487 ± 0.02%' │ '6666666 ± 90091' │ 625956 │
│ 40 │ '0.21.' │ '173.41 ± 0.58%' │ '160.00 ± 3.00' │ '6133121 ± 0.02%' │ '6250000 ± 115030' │ 576671 │
│ 41 │ '0.' │ '203.99 ± 0.42%' │ '194.00 ± 2.00' │ '5070146 ± 0.02%' │ '5154639 ± 53694' │ 490213 │
│ 42 │ '+0.' │ '241.25 ± 22.66%' │ '201.00 ± 3.00' │ '4911464 ± 0.02%' │ '4975124 ± 73164' │ 414506 │
│ 43 │ '-0.' │ '218.37 ± 0.36%' │ '210.00 ± 3.00' │ '4700779 ± 0.01%' │ '4761905 ± 67069' │ 457946 │
│ 44 │ '1.' │ '259.19 ± 0.68%' │ '213.00 ± 12.00' │ '4414993 ± 0.06%' │ '4694836 ± 270057' │ 385819 │
│ 45 │ '00.00' │ '241.93 ± 0.58%' │ '224.00 ± 3.00' │ '4386444 ± 0.02%' │ '4464286 ± 60601' │ 413346 │
│ 46 │ '0.06' │ '252.63 ± 0.54%' │ '237.00 ± 3.00' │ '4164966 ± 0.02%' │ '4219409 ± 54095' │ 395834 │
│ 47 │ '00.6' │ '246.67 ± 0.47%' │ '235.00 ± 3.00' │ '4213483 ± 0.02%' │ '4255319 ± 55026' │ 405395 │
│ 48 │ '.006' │ '246.65 ± 0.45%' │ '235.00 ± 3.00' │ '4202261 ± 0.02%' │ '4255319 ± 55026' │ 405441 │
│ 49 │ '6.0' │ '234.06 ± 1.41%' │ '220.00 ± 3.00' │ '4479981 ± 0.02%' │ '4545455 ± 61149' │ 427244 │
│ 50 │ '06.0' │ '244.08 ± 0.51%' │ '230.00 ± 3.00' │ '4293294 ± 0.02%' │ '4347826 ± 57460' │ 409704 │
│ 51 │ '0.0, {"leadingZeros":false}' │ '246.40 ± 18.92%' │ '211.00 ± 3.00' │ '4683313 ± 0.02%' │ '4739337 ± 66439' │ 405850 │
│ 52 │ '00.00, {"leadingZeros":false}' │ '157.67 ± 18.85%' │ '133.00 ± 3.00' │ '7411830 ± 0.02%' │ '7518797 ± 165856' │ 634230 │
│ 53 │ '0.06, {"leadingZeros":false}' │ '248.16 ± 0.40%' │ '238.00 ± 3.00' │ '4152756 ± 0.01%' │ '4201681 ± 53639' │ 402980 │
│ 54 │ '00.6, {"leadingZeros":false}' │ '138.57 ± 0.46%' │ '131.00 ± 2.00' │ '7515289 ± 0.02%' │ '7633588 ± 118350' │ 721660 │
│ 55 │ '.006, {"leadingZeros":false}' │ '252.97 ± 0.52%' │ '235.00 ± 3.00' │ '4165241 ± 0.02%' │ '4255319 ± 55026' │ 395304 │
│ 56 │ '6.0, {"leadingZeros":false}' │ '244.65 ± 2.18%' │ '215.00 ± 3.00' │ '4456634 ± 0.04%' │ '4651163 ± 65819' │ 408745 │
│ 57 │ '06.0, {"leadingZeros":false}' │ '135.31 ± 0.41%' │ '129.00 ± 2.00' │ '7640617 ± 0.01%' │ '7751938 ± 118351' │ 739058 │
│ 58 │ '+06' │ '219.45 ± 0.54%' │ '207.00 ± 3.00' │ '4758509 ± 0.02%' │ '4830918 ± 71042' │ 455694 │
│ 59 │ '-06' │ '199.26 ± 0.50%' │ '188.00 ± 3.00' │ '5244287 ± 0.02%' │ '5319149 ± 83547' │ 501860 │
│ 60 │ '-06, {"leadingZeros":true}' │ '223.83 ± 23.58%' │ '185.00 ± 3.00' │ '5326968 ± 0.02%' │ '5405405 ± 86256' │ 446766 │
│ 61 │ '-06, {"leadingZeros":false}' │ '142.55 ± 0.48%' │ '134.00 ± 2.00' │ '7331246 ± 0.01%' │ '7462686 ± 113071' │ 701497 │
│ 62 │ '-0.0' │ '241.84 ± 0.48%' │ '228.00 ± 4.00' │ '4309589 ± 0.02%' │ '4385965 ± 78321' │ 413501 │
│ 63 │ '-00.00' │ '253.52 ± 0.45%' │ '241.00 ± 3.00' │ '4093945 ± 0.02%' │ '4149378 ± 52303' │ 394488 │
│ 64 │ '-0.06' │ '259.69 ± 0.47%' │ '246.00 ± 3.00' │ '4012320 ± 0.02%' │ '4065041 ± 50186' │ 385077 │
│ 65 │ '-00.6' │ '256.69 ± 1.87%' │ '244.00 ± 3.00' │ '4057956 ± 0.02%' │ '4098361 ± 51017' │ 389573 │
│ 66 │ '-.006' │ '332.44 ± 3.00%' │ '265.00 ± 10.00' │ '3531261 ± 0.07%' │ '3773585 ± 147984' │ 300810 │
│ 67 │ '-6.0' │ '263.89 ± 0.60%' │ '234.00 ± 8.00' │ '4097733 ± 0.04%' │ '4273504 ± 151275' │ 378942 │
│ 68 │ '-06.0' │ '253.29 ± 0.53%' │ '238.00 ± 3.00' │ '4145647 ± 0.02%' │ '4201681 ± 53639' │ 394803 │
│ 69 │ '+06.0' │ '251.69 ± 0.48%' │ '239.00 ± 4.00' │ '4140632 ± 0.02%' │ '4184100 ± 68874' │ 397308 │
│ 70 │ '-0.0, {"leadingZeros":false}' │ '241.70 ± 2.63%' │ '227.00 ± 3.00' │ '4357623 ± 0.02%' │ '4405286 ± 59000' │ 413733 │
│ 71 │ '-00.00, {"leadingZeros":false}' │ '143.48 ± 0.50%' │ '134.00 ± 2.00' │ '7326644 ± 0.02%' │ '7462686 ± 113071' │ 696973 │
│ 72 │ '-0.06, {"leadingZeros":false}' │ '261.11 ± 0.50%' │ '246.00 ± 4.00' │ '4008635 ± 0.02%' │ '4065041 ± 67191' │ 382978 │
│ 73 │ '-00.6, {"leadingZeros":false}' │ '159.39 ± 19.28%' │ '135.00 ± 2.00' │ '7282801 ± 0.02%' │ '7407408 ± 111390' │ 627382 │
│ 74 │ '-.006, {"leadingZeros":false}' │ '259.48 ± 0.43%' │ '248.00 ± 4.00' │ '3984183 ± 0.02%' │ '4032258 ± 66103' │ 385383 │
│ 75 │ '-6.0, {"leadingZeros":false}' │ '242.42 ± 0.49%' │ '230.00 ± 3.00' │ '4306844 ± 0.02%' │ '4347826 ± 57460' │ 412511 │
│ 76 │ '-06.0, {"leadingZeros":false}' │ '149.91 ± 0.47%' │ '142.00 ± 3.00' │ '6949145 ± 0.01%' │ '7042253 ± 145701' │ 667055 │
│ 77 │ '020211201030005811824' │ '398.99 ± 0.46%' │ '383.00 ± 6.00' │ '2595188 ± 0.02%' │ '2610966 ± 41554' │ 250635 │
│ 78 │ '20211201030005811824' │ '404.62 ± 0.60%' │ '377.00 ± 7.00' │ '2626094 ± 0.02%' │ '2652520 ± 50183' │ 247144 │
│ 79 │ '20.211201030005811824' │ '532.51 ± 0.45%' │ '511.00 ± 6.00' │ '1941535 ± 0.02%' │ '1956947 ± 23251' │ 187792 │
│ 80 │ '0.211201030005811824' │ '561.69 ± 0.49%' │ '536.00 ± 8.00' │ '1852375 ± 0.02%' │ '1865672 ± 27436' │ 178034 │
│ 81 │ '01.0e2, {"leadingZeros":false}' │ '137.61 ± 0.47%' │ '130.00 ± 2.00' │ '7568301 ± 0.01%' │ '7692308 ± 120192' │ 726712 │
│ 82 │ '-01.0e2, {"leadingZeros":false}' │ '142.56 ± 0.45%' │ '135.00 ± 2.00' │ '7287576 ± 0.01%' │ '7407408 ± 111390' │ 701445 │
│ 83 │ '01.0e2' │ '240.82 ± 0.41%' │ '231.00 ± 2.00' │ '4281936 ± 0.01%' │ '4329004 ± 37808' │ 415256 │
│ 84 │ '-01.0e2' │ '247.94 ± 0.45%' │ '236.00 ± 3.00' │ '4184894 ± 0.02%' │ '4237288 ± 53188' │ 403330 │
│ 85 │ '1.0e2' │ '234.23 ± 0.44%' │ '224.00 ± 3.00' │ '4422641 ± 0.02%' │ '4464286 ± 60601' │ 426932 │
│ 86 │ '-1.0e2' │ '232.87 ± 0.39%' │ '224.00 ± 3.00' │ '4421399 ± 0.02%' │ '4464286 ± 59000' │ 429426 │
│ 87 │ '1.0e-2' │ '252.09 ± 1.40%' │ '235.00 ± 3.00' │ '4195980 ± 0.02%' │ '4255319 ± 55026' │ 396678 │
│ 88 │ '420926189200190257681175017717' │ '457.84 ± 0.49%' │ '435.00 ± 6.00' │ '2276895 ± 0.02%' │ '2298851 ± 32152' │ 218416 │
│ 89 │ '420926189200190257681175017717, {"eNotation":false}' │ '459.24 ± 0.51%' │ '436.00 ± 7.00' │ '2275065 ± 0.02%' │ '2293578 ± 37424' │ 217751 │
│ 90 │ '1e-2' │ '239.88 ± 0.58%' │ '223.00 ± 3.00' │ '4419571 ± 0.02%' │ '4484305 ± 61149' │ 416870 │
│ 91 │ '1e+2' │ '220.84 ± 0.55%' │ '205.00 ± 3.00' │ '4780509 ± 0.02%' │ '4878049 ± 70356' │ 452810 │
│ 92 │ '1.e+2' │ '239.00 ± 0.59%' │ '215.00 ± 5.00' │ '4500213 ± 0.03%' │ '4651163 ± 110742' │ 418418 │
│ 93 │ '01.0E2, {"leadingZeros":false}' │ '143.40 ± 0.47%' │ '136.00 ± 2.00' │ '7263442 ± 0.01%' │ '7352941 ± 109746' │ 697333 │
│ 94 │ '-01.0E2, {"leadingZeros":false}' │ '171.73 ± 31.97%' │ '137.00 ± 3.00' │ '7221870 ± 0.01%' │ '7299270 ± 156413' │ 582321 │
│ 95 │ '01.0E2' │ '242.08 ± 0.51%' │ '229.00 ± 3.00' │ '4325618 ± 0.02%' │ '4366812 ± 56468' │ 413088 │
│ 96 │ '-01.0E2' │ '252.94 ± 0.56%' │ '236.00 ± 4.00' │ '4176870 ± 0.02%' │ '4237288 ± 73056' │ 395346 │
│ 97 │ '1.0E2' │ '232.88 ± 0.57%' │ '215.00 ± 3.00' │ '4555156 ± 0.02%' │ '4651163 ± 65819' │ 429405 │
│ 98 │ '-1.0E2' │ '243.11 ± 0.62%' │ '224.00 ± 3.00' │ '4393353 ± 0.02%' │ '4464286 ± 59000' │ 411336 │
│ 99 │ '1.0E-2' │ '246.96 ± 0.50%' │ '233.00 ± 3.00' │ '4237931 ± 0.02%' │ '4291846 ± 55980' │ 404927 │
│ 100 │ 'E-2' │ '134.99 ± 2.96%' │ '124.00 ± 2.00' │ '7900441 ± 0.02%' │ '8064516 ± 132205' │ 740816 │
│ 101 │ 'E2' │ '140.36 ± 0.56%' │ '131.00 ± 3.00' │ '7550293 ± 0.02%' │ '7633588 ± 178912' │ 712435 │
│ 102 │ '0E2' │ '201.54 ± 0.46%' │ '192.00 ± 2.00' │ '5161381 ± 0.01%' │ '5208334 ± 54825' │ 496171 │
│ 103 │ '-0E2' │ '225.11 ± 0.52%' │ '211.00 ± 3.00' │ '4664557 ± 0.02%' │ '4739337 ± 68356' │ 444236 │
│ 104 │ '00E2' │ '269.05 ± 87.93%' │ '136.00 ± 2.00' │ '7192508 ± 0.02%' │ '7352941 ± 109746' │ 410364 │
│ 105 │ '00E2, {"leadingZeros":false}' │ '138.30 ± 0.49%' │ '130.00 ± 2.00' │ '7550691 ± 0.01%' │ '7692308 ± 120191' │ 723045 │
│ 106 │ '0, {"skipLike":{}}' │ '219.05 ± 32.55%' │ '169.00 ± 3.00' │ '5801435 ± 0.02%' │ '5917160 ± 106936' │ 456512 │
│ 107 │ '+12, {"skipLike":{}}' │ '240.95 ± 0.46%' │ '230.00 ± 3.00' │ '4302318 ± 0.01%' │ '4347826 ± 55980' │ 415023 │
│ 108 │ '12+12, {"skipLike":{}}' │ '148.47 ± 0.55%' │ '138.00 ± 3.00' │ '7113214 ± 0.02%' │ '7246377 ± 161030' │ 673545 │
│ 109 │ '12+1212121212, {"skipLike":{}}' │ '142.81 ± 0.44%' │ '136.00 ± 2.00' │ '7256324 ± 0.01%' │ '7352942 ± 109745' │ 700232 │
│ 110 │ '+1212121212' │ '340.97 ± 30.86%' │ '265.00 ± 6.00' │ '3719148 ± 0.02%' │ '3773585 ± 83548' │ 293279 │
│ 111 │ '+1212121212, {"skipLike":{}}' │ '275.53 ± 1.45%' │ '253.00 ± 5.00' │ '3885813 ± 0.02%' │ '3952569 ± 76600' │ 362943 │
│ 112 │ '+12 12' │ '160.42 ± 0.49%' │ '151.00 ± 3.00' │ '6530668 ± 0.02%' │ '6622517 ± 134239' │ 623376 │
│ 113 │ ' +12 12 ' │ '178.11 ± 0.47%' │ '168.00 ± 3.00' │ '5854116 ± 0.02%' │ '5952381 ± 104428' │ 561440 │
│ 114 │ ' +1212 ' │ '273.47 ± 0.53%' │ '257.00 ± 3.00' │ '3837878 ± 0.02%' │ '3891050 ± 45958' │ 365668 │
│ 115 │ '+1212' │ '240.17 ± 0.56%' │ '224.00 ± 4.00' │ '4398442 ± 0.02%' │ '4464286 ± 81169' │ 416365 │
│ 116 │ '+12.12' │ '266.02 ± 0.55%' │ '249.00 ± 3.00' │ '3962845 ± 0.02%' │ '4016064 ± 48977' │ 375915 │
│ 117 │ '-12.12' │ '264.65 ± 0.45%' │ '252.00 ± 3.00' │ '3915889 ± 0.02%' │ '3968254 ± 47811' │ 377860 │
│ 118 │ '-012.12' │ '279.00 ± 0.49%' │ '264.00 ± 3.00' │ '3742167 ± 0.02%' │ '3787879 ± 43539' │ 358420 │
│ 119 │ 'Infinity' │ '151.29 ± 0.56%' │ '139.00 ± 2.00' │ '7014372 ± 0.02%' │ '7194244 ± 105026' │ 660981 │
│ 120 │ '-Infinity' │ '160.98 ± 0.56%' │ '146.00 ± 2.00' │ '6648705 ± 0.03%' │ '6849315 ± 95130' │ 621177 │
│ 121 │ '+Infinity' │ '155.51 ± 0.47%' │ '147.00 ± 2.00' │ '6711700 ± 0.02%' │ '6802722 ± 93830' │ 643043 │
│ 122 │ 'Infinity, {"infinity":true}' │ '193.99 ± 29.73%' │ '153.00 ± 3.00' │ '6439352 ± 0.02%' │ '6535948 ± 130719' │ 515480 │
│ 123 │ '-Infinity, {"infinity":true}' │ '166.22 ± 2.26%' │ '156.00 ± 2.00' │ '6329121 ± 0.01%' │ '6410257 ± 83250' │ 601610 │
│ 124 │ '+Infinity, {"infinity":true}' │ '199.23 ± 27.28%' │ '160.00 ± 2.00' │ '6147450 ± 0.02%' │ '6250000 ± 79115' │ 501934 │
│ 125 │ 'Infinity, {"infinity":false}' │ '152.74 ± 0.51%' │ '143.00 ± 2.00' │ '6869283 ± 0.02%' │ '6993006 ± 99192' │ 654712 │
│ 126 │ '-Infinity, {"infinity":false}' │ '155.22 ± 0.45%' │ '148.00 ± 2.00' │ '6691562 ± 0.01%' │ '6756757 ± 92558' │ 644262 │
│ 127 │ '+Infinity, {"infinity":false}' │ '157.40 ± 0.52%' │ '148.00 ± 2.00' │ '6664533 ± 0.01%' │ '6756757 ± 92558' │ 635325 │
│ 128 │ ' Infinity ' │ '163.25 ± 0.42%' │ '156.00 ± 2.00' │ '6339005 ± 0.01%' │ '6410257 ± 83250' │ 612545 │
│ 129 │ ' -Infinity ' │ '174.97 ± 0.54%' │ '163.00 ± 2.00' │ '6029697 ± 0.02%' │ '6134969 ± 76211' │ 571537 │
│ 130 │ ' +Infinity ' │ '176.04 ± 0.56%' │ '163.00 ± 3.00' │ '6023126 ± 0.02%' │ '6134970 ± 110873' │ 568043 │
└─────────┴──────────────────────────────────────────────────────────┴───────────────────┴──────────────────┴────────────────────────┴────────────────────────┴─────────┘ |
|
It looks exciting. However, I'm still not clear with your comment 3 days ago. I would probably take a pause before checking code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
after: