Skip to content

fix: bun does not require symlink - #6119

Merged
NathanWalker merged 1 commit into
NativeScript:mainfrom
obedm503:fix-bun-isolated-preserve-symlinks
Aug 2, 2026
Merged

fix: bun does not require symlink#6119
NathanWalker merged 1 commit into
NativeScript:mainfrom
obedm503:fix-bun-isolated-preserve-symlinks

Conversation

@obedm503

@obedm503 obedm503 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

When the bun package manager is set in the config, the node --preserve-symlinks flag is set. This affects link: and workspace: dependency resolution in monorepos.

What is the new behavior?

Bun is treated specially and no flag will be passed for it, just like pnpm.

Fixes #6118.

Summary by CodeRabbit

  • Bug Fixes
    • Improved compatibility for Bun projects by disabling the preserve-symlinks compiler option where appropriate.
    • Ensured package-manager-specific compiler behavior works consistently for npm, pnpm, and Bun.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 52f1cb39-9994-4460-800c-3eb46a1d38c8

📥 Commits

Reviewing files that changed from the base of the PR and between 745f3a8 and 9877ee9.

📒 Files selected for processing (2)
  • lib/services/bundler/bundler-compiler-service.ts
  • test/services/bundler/bundler-compiler-service.ts

📝 Walkthrough

Walkthrough

The bundler compiler now disables --preserve-symlinks for Bun projects, matching existing pnpm behavior. Tests now configure package managers and verify the npm, pnpm, and Bun cases.

Changes

Preserve-symlinks package-manager handling

Layer / File(s) Summary
Package-manager eligibility and validation
lib/services/bundler/bundler-compiler-service.ts, test/services/bundler/bundler-compiler-service.ts
The compiler excludes Bun and pnpm from preserve-symlinks use. Tests configure the package-manager stub and verify behavior for npm, pnpm, and Bun.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: nathanwalker

Poem

A rabbit checks the bundler’s track,
Bun and pnpm now hold back.
Npm keeps the symlinks bright,
Tests confirm the choice is right.
Hop, hop—clean paths tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Bun symlink handling fix addressed by the pull request.
Linked Issues check ✅ Passed The changes make Bun skip --preserve-symlinks and add tests, satisfying issue #6118.
Out of Scope Changes check ✅ Passed The implementation and tests remain focused on Bun package-manager symlink handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NathanWalker
NathanWalker merged commit ecdf4a5 into NativeScript:main Aug 2, 2026
12 checks passed
@obedm503
obedm503 deleted the fix-bun-isolated-preserve-symlinks branch August 2, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cli should not use --preserve-symlinks when using bun package manager

2 participants