fix: update plugin gradle script #5578
Conversation
Would that be considered a BREAKING CHANGE? |
|
Do we still support old versions without androidx? |
|
I'm not sure - some plugins may still use it? |
|
Seems unlikely. And anyway they can deps on their include.gradle. |
|
👍 - just don't want to break things by accident in a patch release |
|
@rigor789 i think it should got with android runtime 8.2.0 as we move to gradle 7. But i understand your point |
can still be enabled with `generateBuildConfig` and `generateR`
|
All support packages would be jetpacked (if you wanna call it that) .. this looks good for 8.2 |
There was a problem hiding this comment.
@farfromrefug @triniwiz if you could help clear up questions I posted in the review, that would help a ton with landing this.
| @@ -6,6 +6,12 @@ apply plugin: 'com.android.library' | |||
| apply plugin: 'kotlin-android' | |||
| apply plugin: 'kotlin-android-extensions' | |||
|
|
|||
| def computeKotlinVersion = { -> project.hasProperty("kotlinVersion") ? kotlinVersion : "1.4.21" } | |||
There was a problem hiding this comment.
Can we bump kotlinVersion without too much testing, or is 1.4.21 safer for now?
| @@ -6,6 +6,12 @@ apply plugin: 'com.android.library' | |||
| apply plugin: 'kotlin-android' | |||
| apply plugin: 'kotlin-android-extensions' | |||
|
|
|||
| def computeKotlinVersion = { -> project.hasProperty("kotlinVersion") ? kotlinVersion : "1.4.21" } | |||
| def computeCompileSdkVersion = { -> project.hasProperty("compileSdk") ? compileSdk : 28 as int } | |||
There was a problem hiding this comment.
Should we change the default compileSdk from 28 to 30 (or perhaps newer)?
| @@ -6,6 +6,12 @@ apply plugin: 'com.android.library' | |||
| apply plugin: 'kotlin-android' | |||
| apply plugin: 'kotlin-android-extensions' | |||
|
|
|||
| def computeKotlinVersion = { -> project.hasProperty("kotlinVersion") ? kotlinVersion : "1.4.21" } | |||
| def computeCompileSdkVersion = { -> project.hasProperty("compileSdk") ? compileSdk : 28 as int } | |||
| def computeTargetSdkVersion = { -> project.hasProperty("targetSdk") ? targetSdk : 28 as int } | |||
There was a problem hiding this comment.
Should we change targetSdk to 30 or newer? Believe 30 is minimum from google right now.
| def computeCompileSdkVersion = { -> project.hasProperty("compileSdk") ? compileSdk : 28 as int } | ||
| def computeTargetSdkVersion = { -> project.hasProperty("targetSdk") ? targetSdk : 28 as int } | ||
| def computeBuildToolsVersion = { -> | ||
| project.hasProperty("buildToolsVersion") ? buildToolsVersion : "28.0.3" as String |
There was a problem hiding this comment.
With 8.2 - should we default to build tools 32?
| android { | ||
| kotlinOptions { | ||
| jvmTarget = '1.8' |
There was a problem hiding this comment.
Do we need to set the target to 1.8 with gradle7+? Officially recommended jdk is 11, so this might need to match that?
There was a problem hiding this comment.
we should be able to use more but was not tested https://kotlinlang.org/docs/faq.html#which-versions-of-jvm-does-kotlin-target
let s make it an ext property so we can test easily?
| sourceCompatibility JavaVersion.VERSION_1_8 | ||
| targetCompatibility JavaVersion.VERSION_1_8 |
| } | ||
| } | ||
| def androidXMultidexVersion = project.hasProperty("androidXMultidexVersion") ? project.androidXMultidexVersion : "2.0.1" | ||
| def androidxVersion = project.hasProperty("androidxVersion") ? project.androidxVersion : "1.2.0" |
There was a problem hiding this comment.
not sure about 1.7.0. Maybe 1.6.0
|
superseded by #5774 |
This updates the plugin gradle script: