Skip to content

Commit

Permalink
feat: add android 35 support (#5811)
Browse files Browse the repository at this point in the history
  • Loading branch information
edusperoni authored Aug 19, 2024
1 parent bf9a6cd commit abc7ab4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions lib/common/mobile/emulator-helper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { injector } from "../yok";
export class EmulatorHelper implements Mobile.IEmulatorHelper {
// https://developer.android.com/guide/topics/manifest/uses-sdk-element
public mapAndroidApiLevelToVersion = {
"android-35": "15.0.0",
"android-34": "14.0.0",
"android-33": "13.0.0",
"android-32": "12.0.0",
Expand Down
1 change: 1 addition & 0 deletions packages/doctor/src/android-tools-info.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export class AndroidToolsInfo implements NativeScriptDoctor.IAndroidToolsInfo {
"android-32",
"android-33",
"android-34",
"android-35",
];

const isRuntimeVersionLessThan = (targetVersion: string) => {
Expand Down
3 changes: 2 additions & 1 deletion packages/doctor/test/android-tools-info.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ describe("androidToolsInfo", () => {
"android-32",
"android-33",
"android-34",
"android-35",
];
}
},
Expand Down Expand Up @@ -138,7 +139,7 @@ describe("androidToolsInfo", () => {

it("runtime 8.2.0 should support android-17 - android-34", () => {

This comment has been minimized.

Copy link
@adrian-niculescu

adrian-niculescu Aug 19, 2024

The name of the test case was not changed android-34 > android-35.

const min = 17;
const max = 34;
const max = 35;
assertSupportedRange("8.2.0", min, max);
assertSupportedRange("8.3.0", min, max);
});
Expand Down

0 comments on commit abc7ab4

Please sign in to comment.