Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle methods with pointer type params #116

Conversation

Logikgate
Copy link
Contributor

@Logikgate Logikgate commented Apr 12, 2021

fixes #109.

I was having the same issue as #109 when trying to fix a call to UISaveVideoAtPathToSavedPhotosAlbum. It turns out the runtime would throw an error as soon as you added a method that had a parameter of type interop.Pointer to the ObjCExposedMethods object because GetTypeEncodingType didn't know how to deal with it.

This change also helps fix some of the underlying issues in nstudio/nativescript-plugins#12

Copy link
Member

@rigor789 rigor789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NathanWalker
Copy link
Contributor

@rigor789 when you get a chance, could you release another rc including this patch? Will allow us to confirm with camplus for inclusion in the next ios runtime patch version update.

@NathanWalker NathanWalker changed the base branch from master to release/8-1 July 3, 2021 17:32
@NathanWalker NathanWalker merged commit a84ae27 into NativeScript:release/8-1 Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with UIImageWriteToSavedPhotosAlbum
3 participants