Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

docs: Update SDK root in README #1939

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

goonerify
Copy link

Command line tools path seems to have changed from $ANDROID_SDK_ROOT/cmdline-tools/tools to $ANDROID_SDK_ROOT/cmdline-tools/cmdline-tools

PR Checklist

What is the current state of the documentation article?

What is the new state of the documentation article?

Fixes/Implements/Closes #[Issue Number].

Command line tools path seems to have changed from $ANDROID_SDK_ROOT/cmdline-tools/tools to $ANDROID_SDK_ROOT/cmdline-tools/cmdline-tools
@cla-bot
Copy link

cla-bot bot commented Jan 23, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @goonerify.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@goonerify
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Jan 23, 2021
@cla-bot
Copy link

cla-bot bot commented Jan 23, 2021

The cla-bot has been summoned, and re-checked this pull request!

@goonerify goonerify changed the title Update SDK root in README docs: Update SDK root in README Jan 23, 2021
@goonerify
Copy link
Author

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jan 23, 2021

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@avats-dev avats-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii @goonerify, this looks good. Although as your PR has just one commit, you need it to be a semantic commit to pass the checks. So I think there are two ways for avoiding this:

  • either someone merges this with the failing checks, depends on the reviewers and maintainers.
  • or you might add more commits (i.e. resolve more minor issues along with this PR). Just commit your changes and the PR will get updated by itself.

Please mention if there is any issue relevant to this PR to avoid duplicate works and save time. Thanks for contributing. 🎉

@rigor789
Copy link
Member

The reason I haven't merged this yet, is that I couldn't confirm the path is correct - since both on Windows & macOS these don't exist (cmdline-tools) and are located at <SDK_ROOT>/tools/bin

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants