Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to embed into platform host projects #1799

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vmutafov
Copy link
Contributor

@vmutafov vmutafov commented Jan 2, 2024

No description provided.

@cla-bot cla-bot bot added the cla: yes label Jan 2, 2024
@edusperoni edusperoni changed the base branch from embed to main April 2, 2024 16:17
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be reverted

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert to keep history clean

Comment on lines +182 to +207
implementation "com.google.android.material:material:$androidXMaterialVersion"
implementation "androidx.appcompat:appcompat:$androidXAppCompatVersion"
implementation 'androidx.navigation:navigation-fragment-ktx:2.5.3'
implementation 'androidx.navigation:navigation-ui-ktx:2.5.3'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these needed? It'd mean all apps now depend on material, androidx navigation and appcompat

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file might need to be gitignored (NativeScriptActivity.java isn't currently committed into main)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file might need to be gitignored (NativeScriptApplication.java isn't currently committed into main)

@NathanWalker NathanWalker changed the title feat: add android embedding and merge main feat: ability to embed into platform host projects Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants