-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ability to embed into platform host projects #1799
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert to keep history clean
implementation "com.google.android.material:material:$androidXMaterialVersion" | ||
implementation "androidx.appcompat:appcompat:$androidXAppCompatVersion" | ||
implementation 'androidx.navigation:navigation-fragment-ktx:2.5.3' | ||
implementation 'androidx.navigation:navigation-ui-ktx:2.5.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these needed? It'd mean all apps now depend on material, androidx navigation and appcompat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file might need to be gitignored (NativeScriptActivity.java isn't currently committed into main)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file might need to be gitignored (NativeScriptApplication.java isn't currently committed into main)
No description provided.