feat: dynamically register jni methods and use @FastNative & @CriticalNative #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the new annotations to improve the runtime for our jni calls
edusperoni
reviewed
Nov 8, 2023
Comment on lines
+47
to
57
| @FastNative | ||
| private native void runModule(int runtimeId, String filePath) throws NativeScriptException; | ||
|
|
||
| @FastNative | ||
| private native void runWorker(int runtimeId, String filePath) throws NativeScriptException; | ||
|
|
||
| @FastNative | ||
| private native Object runScript(int runtimeId, String filePath) throws NativeScriptException; | ||
|
|
||
| @FastNative | ||
| private native Object callJSMethodNative(int runtimeId, int javaObjectID, String methodName, int retType, boolean isConstructor, Object... packagedArgs) throws NativeScriptException; |
There was a problem hiding this comment.
not sure if these should be FastNative. FastNative completely disables GC while it's running, and these could likely run for a good while.
callJSMethodNative is even trickier because we can go java->native->java->native multiple times in long running methods
There was a problem hiding this comment.
So the fastest we can go for those would be !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info on
@FastNative&@CriticalNativecan be found here https://developer.android.com/training/articles/perf-jni#faster-native-calls-with-fastnative-and-criticalnative