Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few more minor improvements #1788

Merged
merged 5 commits into from
Nov 28, 2023
Merged

A few more minor improvements #1788

merged 5 commits into from
Nov 28, 2023

Commits on Sep 22, 2023

  1. chore: Remove unused V8 inspector sources 

    These sources are already compiled into the V8 artifacts, and are not
compiled as part of the runtime.
    @ptomato
    ptomato committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    1b9d415 View commit details
    Browse the repository at this point in the history

  2. chore: Remove duplicate code 

    This line shadows a v8::Context already present in the outer scope, so
it's not necessary.
    @ptomato
    ptomato committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    325019f View commit details
    Browse the repository at this point in the history

  3. chore: Make MetadataNode::tryGetExtensionMethodCallbackData more effi… 

    …cient

Two changes suggested by Android Studio. We avoid copying the string
argument, and we check quicker whether the map is empty without having to
count all the entries.
    @ptomato
    ptomato committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    9e4faf8 View commit details
    Browse the repository at this point in the history

  4. chore: Remove ObjectManager dead code 

    JSWrapperConstructorCallback isn't used anywhere.
    @ptomato
    ptomato committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    4773192 View commit details
    Browse the repository at this point in the history

  5. chore: Avoid copy in MetadataNode::IsJavascriptKeyword 

    Noticed while fixing static initialization of keywords set, see next
commit.
    @ptomato
    ptomato committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    0cd405e View commit details
    Browse the repository at this point in the history