Draft
Conversation
Prevent cryptic build failures (e.g. AAPT errors) caused by invalid characters in NATIVEPHP_APP_ID. Adds centralized AppIdValidator with platform-specific rules and wires it into InstallCommand, RunCommand, and ValidatesAppConfig trait. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppIdValidatorclass with platform-specific validation rules to catch invalidNATIVEPHP_APP_IDvalues before they cause cryptic build failures (e.g. Android AAPT errors from hyphens in package names)InstallCommand(interactive prompt rejects invalid input),RunCommand, andValidatesAppConfigtrait (both exit with clear error messages)[a-zA-Z][a-zA-Z0-9_]*— no hyphens allowed[a-zA-Z0-9]([a-zA-Z0-9-]*[a-zA-Z0-9])?— hyphens allowed mid-segmentTest plan
AppIdValidatorTestcovering valid/invalid IDs for both platforms, cross-platform validation, and prompt validationnative:installprompt rejectscom.example.my-appinteractivelynative:runexits with clear error when.envcontains an invalid app IDnative:build(which usesValidatesAppConfig) also catches invalid IDs🤖 Generated with Claude Code