Add auto-updater API to Electron server #213
Open
+149
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrates new auto-updater routes for checking updates and installing them. Also includes event listeners to notify Laravel about update states like availability, download completion, and errors. This enhances the app's ability to manage updates seamlessly.
SRWieZ
requested changes
Apr 28, 2025
|
Oh, okay, I'll check that again. |
This commit introduces a new "download-progress" event listener in the autoUpdater module. It forwards progress details, such as percentage and speed, to Laravel via the notifyLaravel function. Additionally, the electron-updater module is now mocked in tests for better coverage.
|
@SRWieZ I fixed the test and added the DownloadProgress event |
SRWieZ
approved these changes
Apr 29, 2025
gwleuverink
reviewed
Apr 29, 2025
| @@ -0,0 +1,61 @@ | |||
| import express from "express"; | |||
| import electronUpdater from "electron-updater"; | |||
There was a problem hiding this comment.
Nitpick: Importing the autoUpdater directly might decrease bundle size (untested)
| const router = express.Router(); | ||
| const { autoUpdater } = electronUpdater; | ||
| router.post("/check-for-updates", (req, res) => { | ||
| autoUpdater.checkForUpdates(); |
There was a problem hiding this comment.
Idea: If you add a guard clause here you might be able to prevent the download from happening multiple times.
Set a Boolean & make sure to reset it when the download finishes/fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates new auto-updater routes for checking updates and installing them. Also includes event listeners to notify Laravel about update states like availability, download completion, and errors. This enhances the app's ability to manage updates seamlessly.
PR:
NativePHP/laravel: NativePHP/laravel#570