Cleanup the bootstrapping file to make it easier to interpret #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is largely a quality of life improvement, with the goal to make it easier for developers to interpret what is happening when a NativePHP application boots.
The real functionality of the package, which is the bootstrapping logic, has gone from over 100 lines down to just this:
I have split the changes up into separate and relatively isolated commits, to try and make it easier to follow.
I have bumped the
menubar
dependency, and added missingeslint
dependencies that were preventing it from running.I have removed the
yarn.lock
file, since it's unclear whether the package is using yarn or NPM.If there are any changes you would like made before this could be approved, please let me know as I'm actively keen to contribute to NativePHP, and have a lot more ideas that will stem off of this PR.