Fixed a bug where the remote user operations cache always used the sa… #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivakegg
approved these changes
Jul 30, 2024
|
Excellent! |
|
|
||
| // ensure that we get the other user details, not the cached user details | ||
| ProxiedUserDetails newReturnedUser = remote.getRemoteUser(otherPrincipal); | ||
| assertNotEquals(returnedUser, newReturnedUser); |
There was a problem hiding this comment.
add an assert for the expected auths as well as that they are different from the cached auths?
There was a problem hiding this comment.
When you get a cache hit you literally get the exact same object (down to the reference) so i think this is sufficient..
FineAndDandy
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…me key.