Removing error for large document sizes #2463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps we could complete the other PR that adds the document size metrics elsewhere first? I'm a little worried that this will get merged and the new feature won't - and we'll lose a tool for tracking causes of tserver memory issues as a result. |
That's fair - I can make those changes in this PR instead of splitting them out. |
ivakegg
reviewed
Jul 9, 2024
| // if more than 1M, then info | ||
| else if (bytes > (ONE_M)) { | ||
| if (bytes > (ONE_M)) { |
There was a problem hiding this comment.
Perhaps too much info now. Make this ONE_HUNDRED_M and the debug below for ONE_M.
mineralntl
force-pushed
the
task/remove-unnecessary-size-error
branch
from
ce75e02
to
3617f42
Compare
mineralntl
force-pushed
the
task/remove-unnecessary-size-error
branch
from
3617f42
to
786aa48
Compare
mineralntl
force-pushed
the
task/remove-unnecessary-size-error
branch
from
786aa48
to
45d3e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the quick and dirty removing of error logging for large Document sizes. Adding the actual document size to the metrics coming in a follow-on PR.