Feature/separate webservice hdfs config #2453
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivakegg
force-pushed
the
feature/separateWebserviceHdfsConfig
branch
from
bb4426e
to
35096c7
Compare
apmoriarty
approved these changes
Jun 28, 2024
alerman
approved these changes
Jul 8, 2024
hlgp
reviewed
Jul 17, 2024
| @@ -114,6 +114,10 @@ | |||
| <!-- the zookeeper configuration (could be something like file:///opt/datawave/zookeeper-warehouse/conf/zoo.cfg, or the zookeeper list (somehost1:2181,somehost2:2181,…)--> | |||
| <property name="zookeeperConfig" value="${datawave.query.logic.logics.BaseEventQuery.zookeeperConfig}" /> | |||
|
|
|||
| <!-- This is injected via BaseEventQueryConfiguration.java and configured via configuration properties --> | |||
| <!-- the list of directories in which the query service puts its caches (selection always made on query service side) --> | |||
| <property name="localIvaratorCacheDirConfigs" ref="baseEventQueryLocalIvaratorCacheDirConfigs" /> | |||
There was a problem hiding this comment.
plug for future rename: since "local" is relative, maybe simply call them what they are. webserverIvaratorCacheDirConfigs and tserverIvaratorCacheDirConfigs
hlgp
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will added a localIvaratorCacheDirConfigs separate from the ivaratorCacheDirConfigs to allow us to configure ivarator directories differently between the tservers and the webserver/query microservices.
I created a branch in the query microservices starter that is updated as well:
https://github.com/NationalSecurityAgency/datawave-spring-boot-starter-query/compare/feature/separateWebserviceHdfsConfig