Add logging of query IDs via QueryLogIterator class #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the query option tserver.logging.active to enable logging of query IDs to the TServer logs. Created the class QueryLogIterator to handle this. Logs the start and end of each method called. Fixes #2305
* Fix CountQueryTest issues * Remove unecessary changes * Code formatting
Add TserverLogging test to verify that queryLogIterator is created and added to the iterator stack when desired. Additionally, move tserver.logging.active property to QueryParameters, and ensure that if specified, the query parameter will override the configuration settings. Additionally, make it possible to set the tserver active logging flag from a ShardQueryLogic configuration setting in the QueryLogicFactory.xml file.
Added the query option tserver.logging.active to enable logging of query IDs to the TServer logs. Created the class QueryLogIterator to handle this. Logs the start and end of each method called. Fixes #2305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create QueryLogIterator class that logs a query's ID to the TServer logs
Resolves #2305
Updated the PR to merge code from NSA/log-iterator to NSA/origin instead of from SethSmucker/log-iterator.