Make #MATCHES_IN_GROUP work with a number #2434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable regex matching for functions in GroupingRequiredFilteredFunctions. Increase test coverage. Verify numeric regex matching works. Update existing unit tests in anticipating of merging in datawave-type-utils/pull/11 which makes changes to how numeric regexes are normalized. Fixes #2400
ivakegg
requested changes
Jun 26, 2024
...e/query-core/src/main/java/datawave/query/jexl/functions/EvaluationPhaseFilterFunctions.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/test/java/datawave/query/jexl/functions/GroupingFiltersIngest.java
Outdated
Show resolved
Hide resolved
.../query-core/src/main/java/datawave/query/jexl/functions/GroupingRequiredFilterFunctions.java
Outdated
Show resolved
Hide resolved
ivakegg
reviewed
Jun 26, 2024
| @@ -20,6 +21,8 @@ | |||
| import java.util.stream.Stream; | |||
| import java.util.stream.StreamSupport; | |||
|
|
|||
There was a problem hiding this comment.
I think we can revert the changes to this class entirely.
ivakegg
approved these changes
Jun 26, 2024
apmoriarty
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable regex matching for functions in GroupingRequiredFilteredFunctions. Increase test coverage. Verify numeric regex matching works. Update existing unit tests in anticipating of merging in datawave-type-utils/pull/11 which makes changes to how numeric regexes are normalized.
Fixes #2400
NOTE: This PR is dependent on the work in NationalSecurityAgency/datawave-type-utils#11 and should not be merged in before that. (completed, type-utils updated to version 3.0.1)