Add option to sort query by field cardinality #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from the DatawaveMetadata table
apmoriarty
force-pushed
the
task/metadata-utils-field-cardinality
branch
from
9dac86c
to
0066649
Compare
ivakegg
requested changes
Jun 28, 2024
| @@ -2796,6 +2797,20 @@ public Tuple2<CloseableIterable<QueryPlan>,Boolean> getQueryRanges(ScannerFactor | |||
| return new Tuple2<>(ranges, needsFullTable); | |||
| } | |||
|
|
|||
| protected ASTJexlScript timedSortQueryBeforeGlobalIndex(ShardQueryConfiguration config, MetadataHelper metadataHelper) throws DatawaveQueryException { | |||
| return visitorManager.timedVisit(config.getTimers(), "SortQueryBeforeGlobalIndex", () -> { | |||
There was a problem hiding this comment.
I am missing if there is a test that covers this change. Is there a way to test that it did what we want? Maybe testing the final plan to see that is is different when isSortQueryBeforeGlobalIndex is set to true?
There was a problem hiding this comment.
Added a test to verify the query terms are re-ordered by field cardinality and discovered another problem with the RebuildingScannerHelper which led to it's removal from a test.
…e test framework to not use rebuilding scanner helper due to incompatible usages of interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the sortQueryBeforeGlobalIndex option to get field cardinality from the DatawaveMetadata table
FOO.min() == 1Note: until metadata-utils #37 is merged and the 4.0.2 tag created, this build will fail.