Adding Badge and Adding Microservice build and test to gitlab action #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwomeara
requested changes
Jun 20, 2024
|
I unintentionally lead you astray... Instead of running the microservice build and test, i wanted to run the docker compose tests. here's the entry for that. you should be able to just swap this for the one you added. sorry about that. datawave/.github/workflows/tests.yml Line 158 in eb62d64 |
|
One thing that might not work if one of the jobs is failing (even though the overall status is successful) is the ability to merge a PR. I think all of the jobs have to be passing to merge a PR. I created a PR against your PR which should fail the microservice build and let us know one way or the other. |
task/GITHUB-2414 GitHub action update task/GITHUB-2414 GitHub action update task/GITHUB-2414 GitHub action update task/GITHUB-2414 GitHub action task/GITHUB-2414 GitHub action task/GITHUB-2414 GitHub action task/GITHUB-2414 GitHub action task/GITHUB-2414 GitHub action task/GITHUB-2414 GitHub action task/GITHUB-2414 GitHub action task/GITHUB-2414 GitHub action Revert "task/GITHUB-2414 GitHub action" This reverts commit 66bb527. task/GITHUB-2414 GitHub action github action update github action update
doublejai
force-pushed
the
task/GITHUB-2414
branch
from
51ad7fd
to
5a0136f
Compare
doublejai
force-pushed
the
task/GITHUB-2414
branch
from
9879140
to
59b2333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.